Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/runtime/dart_sdk.js

Side-by-side diff isn't available for this file because of its large size.
Issue 2010693002: Add a type on lazyAsJsDate (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Review fixes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | tool/input_sdk/private/js_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart_sdk.js
diff --git a/lib/runtime/dart_sdk.js b/lib/runtime/dart_sdk.js
index 525eb91e52447c65eb37ab7cb5a5c289ece822e8..fb2df7e4f78da26c76a13991084f240a84794a1c 100644
--- a/lib/runtime/dart_sdk.js
+++ b/lib/runtime/dart_sdk.js
@@ -9309,7 +9309,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
}
static lazyAsJsDate(receiver) {
if (receiver.date === void 0) {
- receiver.date = new Date(dart.dload(receiver, 'millisecondsSinceEpoch'));
+ receiver.date = new Date(receiver.millisecondsSinceEpoch);
}
return receiver.date;
}
@@ -9380,11 +9380,11 @@ dart_library.library('dart_sdk', null, /* Imports */[
stringFromCharCode: [core.String, [core.int]],
stringConcatUnchecked: [core.String, [core.String, core.String]],
flattenString: [core.String, [core.String]],
- getTimeZoneName: [core.String, [dart.dynamic]],
- getTimeZoneOffsetInMinutes: [core.int, [dart.dynamic]],
+ getTimeZoneName: [core.String, [core.DateTime]],
+ getTimeZoneOffsetInMinutes: [core.int, [core.DateTime]],
valueFromDecomposedDate: [dart.dynamic, [dart.dynamic, dart.dynamic, dart.dynamic, dart.dynamic, dart.dynamic, dart.dynamic, dart.dynamic, dart.dynamic]],
patchUpY2K: [dart.dynamic, [dart.dynamic, dart.dynamic, dart.dynamic]],
- lazyAsJsDate: [dart.dynamic, [dart.dynamic]],
+ lazyAsJsDate: [dart.dynamic, [core.DateTime]],
getYear: [dart.dynamic, [core.DateTime]],
getMonth: [dart.dynamic, [core.DateTime]],
getDay: [dart.dynamic, [core.DateTime]],
« no previous file with comments | « no previous file | tool/input_sdk/private/js_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698