Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010693002: Add a type on lazyAsJsDate (Closed)

Created:
4 years, 7 months ago by Alan Knight
Modified:
4 years, 7 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M lib/runtime/dart_sdk.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tool/input_sdk/private/js_helper.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Alan Knight
4 years, 7 months ago (2016-05-25 00:19:00 UTC) #2
Jacob
https://codereview.chromium.org/2010693002/diff/1/lib/runtime/dart_sdk.js File lib/runtime/dart_sdk.js (left): https://codereview.chromium.org/2010693002/diff/1/lib/runtime/dart_sdk.js#oldcode9275 lib/runtime/dart_sdk.js:9275: static getTimeZoneOffsetInMinutes(receiver) { fix arg types for this method ...
4 years, 7 months ago (2016-05-25 00:30:03 UTC) #4
Jennifer Messerly
lgtm https://codereview.chromium.org/2010693002/diff/1/lib/runtime/dart_sdk.js File lib/runtime/dart_sdk.js (left): https://codereview.chromium.org/2010693002/diff/1/lib/runtime/dart_sdk.js#oldcode9265 lib/runtime/dart_sdk.js:9265: static getTimeZoneName(receiver) { Maybe add a type here ...
4 years, 7 months ago (2016-05-25 00:30:13 UTC) #5
Alan Knight
On 2016/05/25 00:30:03, Jacob wrote: > https://codereview.chromium.org/2010693002/diff/1/lib/runtime/dart_sdk.js > File lib/runtime/dart_sdk.js (left): > > https://codereview.chromium.org/2010693002/diff/1/lib/runtime/dart_sdk.js#oldcode9275 > ...
4 years, 7 months ago (2016-05-25 00:34:33 UTC) #6
Alan Knight
On 2016/05/25 00:30:03, Jacob wrote: > https://codereview.chromium.org/2010693002/diff/1/lib/runtime/dart_sdk.js > File lib/runtime/dart_sdk.js (left): > > https://codereview.chromium.org/2010693002/diff/1/lib/runtime/dart_sdk.js#oldcode9275 > ...
4 years, 7 months ago (2016-05-25 00:34:45 UTC) #7
Alan Knight
4 years, 7 months ago (2016-05-25 00:35:27 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
629a7d650cfc02187c7d659b724e8abac85a66d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698