Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010683002: Use hasRareData() rather than null-checking elementRareData(). (Closed)

Created:
4 years, 7 months ago by szager1
Modified:
4 years, 6 months ago
Reviewers:
atotic, eae, atotic1
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use hasRareData() rather than null-checking elementRareData(). R=eae@chromium.org,atotic@chromium.org BUG= Committed: https://crrev.com/4de569e7c5581dc94963e3a61d27c4c891cf3223 Cr-Commit-Position: refs/heads/master@{#397851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
szager1
4 years, 7 months ago (2016-05-25 00:08:35 UTC) #1
atotic1
On 2016/05/25 00:08:35, szager1 wrote: LGTM.
4 years, 7 months ago (2016-05-25 00:17:23 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-25 00:18:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010683002/1
4 years, 7 months ago (2016-05-25 00:18:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/234886)
4 years, 7 months ago (2016-05-25 02:41:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010683002/1
4 years, 6 months ago (2016-06-03 19:27:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 00:09:25 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:12:53 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4de569e7c5581dc94963e3a61d27c4c891cf3223
Cr-Commit-Position: refs/heads/master@{#397851}

Powered by Google App Engine
This is Rietveld 408576698