Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010673002: Add timeline event for weak handle processing. (Closed)

Created:
4 years, 7 months ago by rmacnak
Modified:
4 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M runtime/vm/gc_marker.cc View 1 3 chunks +12 lines, -5 lines 0 comments Download
M runtime/vm/scavenger.cc View 1 2 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 7 months ago (2016-05-25 02:10:46 UTC) #2
siva
lgtm https://chromiumcodereview.appspot.com/2010673002/diff/20001/runtime/vm/gc_marker.cc File runtime/vm/gc_marker.cc (right): https://chromiumcodereview.appspot.com/2010673002/diff/20001/runtime/vm/gc_marker.cc#newcode655 runtime/vm/gc_marker.cc:655: Thread* thread = Thread::Current(); We should look at ...
4 years, 7 months ago (2016-05-25 17:39:13 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/2010673002/diff/20001/runtime/vm/scavenger.cc File runtime/vm/scavenger.cc (right): https://chromiumcodereview.appspot.com/2010673002/diff/20001/runtime/vm/scavenger.cc#newcode806 runtime/vm/scavenger.cc:806: Thread* thread = Thread::Current(); On 2016/05/25 17:39:12, siva wrote: ...
4 years, 7 months ago (2016-05-25 17:53:27 UTC) #4
rmacnak
4 years, 7 months ago (2016-05-25 17:55:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
18c87ab02c62fb2cb5737bf2bc8f7c6b27191e66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698