chrome/browser/resources/settings/about_page/about_page.js - Issue 2010653003: MD Settings: About page, implementing channel switcher dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2010653003: MD Settings: About page, implementing channel switcher dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/settings_strings.grdp ('K') | « chrome/app/settings_strings.grdp ('k') | chrome/browser/resources/settings/about_page/about_page_browser_proxy.js » ('j') | chrome/browser/resources/settings/about_page/channel_switcher_dialog.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/about_page/about_page.js

diff --git a/chrome/browser/resources/settings/about_page/about_page.js b/chrome/browser/resources/settings/about_page/about_page.js

index e73128504178068b9ab90af169351b96df3bb80e..2f3e20643447a763da7ac49434982876ef5826f1 100644

--- a/chrome/browser/resources/settings/about_page/about_page.js

+++ b/chrome/browser/resources/settings/about_page/about_page.js

@@ -202,16 +202,8 @@ Polymer({

isTargetChannelMoreStable_: function() {

assert(this.currentChannel_.length > 0);

assert(this.targetChannel_.length > 0);

- // List of channels in increasing stability order.

- var channelList = [

- BrowserChannel.DEV,

- BrowserChannel.BETA,

- BrowserChannel.STABLE,

- ];

- var currentIndex = channelList.indexOf(this.currentChannel_);

- var targetIndex = channelList.indexOf(this.targetChannel_);

- return currentIndex < targetIndex;

+ return settings.isTargetChannelMoreStable(

+ this.currentChannel_, this.targetChannel_);

/** @private */