Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2010653003: MD Settings: About page, implementing channel switcher dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-about-page' contains version and OS related 6 * @fileoverview 'settings-about-page' contains version and OS related
7 * information. 7 * information.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-about-page', 10 is: 'settings-about-page',
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 }, 195 },
196 196
197 <if expr="chromeos"> 197 <if expr="chromeos">
198 /** 198 /**
199 * @return {boolean} 199 * @return {boolean}
200 * @private 200 * @private
201 */ 201 */
202 isTargetChannelMoreStable_: function() { 202 isTargetChannelMoreStable_: function() {
203 assert(this.currentChannel_.length > 0); 203 assert(this.currentChannel_.length > 0);
204 assert(this.targetChannel_.length > 0); 204 assert(this.targetChannel_.length > 0);
205 205 return settings.isTargetChannelMoreStable(
206 // List of channels in increasing stability order. 206 this.currentChannel_, this.targetChannel_);
207 var channelList = [
208 BrowserChannel.DEV,
209 BrowserChannel.BETA,
210 BrowserChannel.STABLE,
211 ];
212 var currentIndex = channelList.indexOf(this.currentChannel_);
213 var targetIndex = channelList.indexOf(this.targetChannel_);
214 return currentIndex < targetIndex;
215 }, 207 },
216 208
217 /** @private */ 209 /** @private */
218 onDetailedBuildInfoTap_: function() { 210 onDetailedBuildInfoTap_: function() {
219 var animatedPages = /** @type {!SettingsAnimatedPagesElement} */ ( 211 var animatedPages = /** @type {!SettingsAnimatedPagesElement} */ (
220 this.$.pages); 212 this.$.pages);
221 animatedPages.setSubpageChain(['detailed-build-info']); 213 animatedPages.setSubpageChain(['detailed-build-info']);
222 }, 214 },
223 215
224 /** @private */ 216 /** @private */
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 }, 251 },
260 </if> 252 </if>
261 253
262 <if expr="_google_chrome"> 254 <if expr="_google_chrome">
263 /** @private */ 255 /** @private */
264 onReportIssueTap_: function() { 256 onReportIssueTap_: function() {
265 this.browserProxy_.openFeedbackDialog(); 257 this.browserProxy_.openFeedbackDialog();
266 }, 258 },
267 </if> 259 </if>
268 }); 260 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698