Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2010653003: MD Settings: About page, implementing channel switcher dialog. (Closed)

Created:
4 years, 7 months ago by dpapad
Modified:
4 years, 7 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: About page, implementing channel switcher dialog. This dialog allows the user to switch between stable, beta and dev channels. Will be hooked up in follow up CL. BUG=546841 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/289aedeff070843ff814f8b6571be4be7e11fba0 Cr-Commit-Position: refs/heads/master@{#396370}

Patch Set 1 : Cleanup #

Total comments: 13

Patch Set 2 : Address comments. #

Total comments: 5

Patch Set 3 : Address comments. #

Messages

Total messages: 18 (9 generated)
dpapad
https://codereview.chromium.org/2010653003/diff/40001/chrome/browser/resources/settings/about_page/detailed_build_info.html File chrome/browser/resources/settings/about_page/detailed_build_info.html (right): https://codereview.chromium.org/2010653003/diff/40001/chrome/browser/resources/settings/about_page/detailed_build_info.html#newcode3 chrome/browser/resources/settings/about_page/detailed_build_info.html:3: <link rel="import" href="chrome://md-settings/about_page/channel_switcher_dialog.html"> Even though <settings-channel-switcher-dialog> is not hooked ...
4 years, 7 months ago (2016-05-25 23:30:00 UTC) #2
dpapad
Screenshots at http://imgur.com/a/7Bree. https://codereview.chromium.org/2010653003/diff/80001/chrome/browser/resources/settings/about_page/detailed_build_info.html File chrome/browser/resources/settings/about_page/detailed_build_info.html (right): https://codereview.chromium.org/2010653003/diff/80001/chrome/browser/resources/settings/about_page/detailed_build_info.html#newcode3 chrome/browser/resources/settings/about_page/detailed_build_info.html:3: <link rel="import" href="chrome://md-settings/about_page/channel_switcher_dialog.html"> Even though <settings-channel-switcher-dialog> ...
4 years, 7 months ago (2016-05-26 00:18:03 UTC) #8
dschuyler
https://codereview.chromium.org/2010653003/diff/80001/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2010653003/diff/80001/chrome/app/settings_strings.grdp#newcode47 chrome/app/settings_strings.grdp:47: <message name="IDS_SETTINGS_ABOUT_PAGE_CHANGE_CHANNEL_AND_POWERWASH" desc="The label for the button for channel ...
4 years, 7 months ago (2016-05-26 01:35:50 UTC) #9
dpapad
https://codereview.chromium.org/2010653003/diff/80001/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2010653003/diff/80001/chrome/app/settings_strings.grdp#newcode47 chrome/app/settings_strings.grdp:47: <message name="IDS_SETTINGS_ABOUT_PAGE_CHANGE_CHANNEL_AND_POWERWASH" desc="The label for the button for channel ...
4 years, 7 months ago (2016-05-26 17:58:55 UTC) #10
dschuyler
LGTM (with some import path changes). https://codereview.chromium.org/2010653003/diff/100001/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2010653003/diff/100001/chrome/app/settings_strings.grdp#newcode797 chrome/app/settings_strings.grdp:797: <message name="IDS_SETTINGS_SITE_SETTINGS" desc="Text ...
4 years, 7 months ago (2016-05-26 23:32:09 UTC) #11
dpapad
https://codereview.chromium.org/2010653003/diff/100001/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html File chrome/browser/resources/settings/about_page/channel_switcher_dialog.html (right): https://codereview.chromium.org/2010653003/diff/100001/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html#newcode8 chrome/browser/resources/settings/about_page/channel_switcher_dialog.html:8: <link rel="import" href="chrome://md-settings/settings_shared_css.html"> On 2016/05/26 at 23:32:09, dschuyler wrote: ...
4 years, 7 months ago (2016-05-27 01:26:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010653003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010653003/120001
4 years, 7 months ago (2016-05-27 01:27:08 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:120001)
4 years, 7 months ago (2016-05-27 03:04:51 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 03:06:09 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/289aedeff070843ff814f8b6571be4be7e11fba0
Cr-Commit-Position: refs/heads/master@{#396370}

Powered by Google App Engine
This is Rietveld 408576698