Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2010633004: Launch WebAPK if notification opens URL within WebAPK scope (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Launch WebAPK if notification opens URL within WebAPK scope BUG=609122 Committed: https://crrev.com/8c10ae7eb7ac553497d8c24852475b17dd1ffa51 Cr-Commit-Position: refs/heads/master@{#397853}

Patch Set 1 : #

Total comments: 5

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java View 1 3 chunks +14 lines, -3 lines 0 comments Download
M chrome/android/webapk/libs/client/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/NavigationClient.java View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
pkotwicz
Xi can you please take a look?
4 years, 7 months ago (2016-05-25 16:00:41 UTC) #4
Xi Han
lgtm
4 years, 7 months ago (2016-05-26 20:11:48 UTC) #5
pkotwicz
Peter Beverloo can you please take a look?
4 years, 7 months ago (2016-05-26 20:31:11 UTC) #7
pkotwicz
Peter Beverloo Ping!
4 years, 6 months ago (2016-05-31 00:02:12 UTC) #8
Peter Beverloo
lgtm https://codereview.chromium.org/2010633004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java (right): https://codereview.chromium.org/2010633004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java#newcode52 chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java:52: NavigationClient.launchWebApk(context, webApkPackageName, url); This is the code path ...
4 years, 6 months ago (2016-05-31 13:19:29 UTC) #9
pkotwicz
rsesek@ Can you take a look at this CL from a security perspective? Do we ...
4 years, 6 months ago (2016-05-31 19:09:59 UTC) #11
Robert Sesek
On 2016/05/31 19:09:59, pkotwicz wrote: > rsesek@ Can you take a look at this CL ...
4 years, 6 months ago (2016-06-01 16:42:09 UTC) #12
pkotwicz
dfalcantara@ for chrome/android/java OWNERS rsesek@: Yes, the WebAPK is validated when the service connection for ...
4 years, 6 months ago (2016-06-01 23:41:39 UTC) #14
gone
https://codereview.chromium.org/2010633004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java (right): https://codereview.chromium.org/2010633004/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java#newcode55 chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java:55: } 1) newline after the brace 2) Don't call ...
4 years, 6 months ago (2016-06-02 18:49:40 UTC) #15
Robert Sesek
On 2016/06/01 23:41:39, pkotwicz wrote: > rsesek@: Yes, the WebAPK is validated when the service ...
4 years, 6 months ago (2016-06-02 18:50:36 UTC) #16
pkotwicz
dfalcantara@ can you please take another look? https://codereview.chromium.org/2010633004/diff/40001/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/NavigationClient.java File chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/NavigationClient.java (right): https://codereview.chromium.org/2010633004/diff/40001/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/NavigationClient.java#newcode32 chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/NavigationClient.java:32: new ComponentName(webApkPackageName, ...
4 years, 6 months ago (2016-06-03 18:08:54 UTC) #17
gone
lgtm
4 years, 6 months ago (2016-06-03 18:17:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010633004/60001
4 years, 6 months ago (2016-06-03 23:07:59 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 6 months ago (2016-06-04 00:31:17 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:32:44 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c10ae7eb7ac553497d8c24852475b17dd1ffa51
Cr-Commit-Position: refs/heads/master@{#397853}

Powered by Google App Engine
This is Rietveld 408576698