Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: ui/accessibility/platform/ax_platform_node_mac.mm

Issue 2010493005: a11y/Mac: Add screenreader support for SubtleNotificationView announcements. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/platform/ax_platform_node_mac.mm
diff --git a/ui/accessibility/platform/ax_platform_node_mac.mm b/ui/accessibility/platform/ax_platform_node_mac.mm
index 346cb7168571392f59d609106ff894c08bd0b7d8..a2d088af0640cf91de1e73a49c2d040eaca03f86 100644
--- a/ui/accessibility/platform/ax_platform_node_mac.mm
+++ b/ui/accessibility/platform/ax_platform_node_mac.mm
@@ -8,6 +8,7 @@
#include <stddef.h>
#include "base/macros.h"
+#import "base/mac/sdk_forward_declarations.h"
#include "base/strings/sys_string_conversions.h"
#include "ui/accessibility/ax_node_data.h"
#include "ui/accessibility/ax_view_state.h"
@@ -508,6 +509,18 @@ void AXPlatformNodeMac::NotifyAccessibilityEvent(ui::AXEvent event_type) {
// Add mappings between ui::AXEvent and NSAccessibility notifications using
// the EventMap above. This switch contains exceptions to those mappings.
switch (event_type) {
+ case ui::AX_EVENT_ALERT: {
+ NSString* announcement = base::SysUTF8ToNSString(
+ GetData().GetStringAttribute(ui::AX_ATTR_NAME));
+ NSDictionary* notification_info = @{
+ NSAccessibilityAnnouncementKey : announcement,
+ NSAccessibilityPriorityKey : @(NSAccessibilityPriorityHigh)
+ };
+ NSAccessibilityPostNotificationWithUserInfo(
+ [NSApp mainWindow], NSAccessibilityAnnouncementRequestedNotification,
+ notification_info);
+ return;
+ } break;
tapted 2016/07/11 03:46:47 nit: no need for break
Patti Lor 2016/07/12 00:04:36 Done.
case ui::AX_EVENT_TEXT_CHANGED:
// If the view is a user-editable textfield, this should change the value.
if (GetData().role == ui::AX_ROLE_TEXT_FIELD) {

Powered by Google App Engine
This is Rietveld 408576698