Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2010493004: Ignore duplicate HOVER events (Closed)

Created:
4 years, 7 months ago by dmazzoni
Modified:
4 years, 6 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore duplicate HOVER events Each time your finger moved we were interrupting and speaking the same object again. BUG=613694 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bab8dc06fc0c1df0b72ecac3e055dabb6dde2188 Cr-Commit-Position: refs/heads/master@{#396943}

Patch Set 1 #

Patch Set 2 : Check for valid currentRange #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
dmazzoni
4 years, 7 months ago (2016-05-25 17:19:36 UTC) #3
dmazzoni
Friendly ping
4 years, 6 months ago (2016-05-31 18:09:35 UTC) #4
David Tseng
lgtm
4 years, 6 months ago (2016-05-31 18:39:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010493004/20001
4 years, 6 months ago (2016-05-31 20:57:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 21:56:29 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 21:57:26 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bab8dc06fc0c1df0b72ecac3e055dabb6dde2188
Cr-Commit-Position: refs/heads/master@{#396943}

Powered by Google App Engine
This is Rietveld 408576698