mash/wm/window_manager.cc - Issue 2010473003: Wires up shelf to panel and dock layoutmanagers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/wm/window_manager.cc

Issue 2010473003: Wires up shelf to panel and dock layoutmanagers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moar Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mash/wm/window_manager.cc

diff --git a/mash/wm/window_manager.cc b/mash/wm/window_manager.cc

index 614aaf6bc40e5caadca455ed81a893b31c68c045..929c91cf8d5c049888fb7d371152955d28f2143d 100644

--- a/mash/wm/window_manager.cc

+++ b/mash/wm/window_manager.cc

@@ -84,8 +84,10 @@ mus::Window* WindowManager::NewTopLevelWindow(

mus::Window* root = root_controller_->root();

DCHECK(root);

+ // TODO(sky): panels need a different frame, http:://crbug.com/614362.

const bool provide_non_client_frame =

- GetWindowType(*properties) == mus::mojom::WindowType::WINDOW;

+ GetWindowType(*properties) == mus::mojom::WindowType::WINDOW ||

+ GetWindowType(*properties) == mus::mojom::WindowType::PANEL;

if (provide_non_client_frame)

(*properties)[mus::mojom::kWaitForUnderlay_Property].clear();