Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2010473003: Wires up shelf to panel and dock layoutmanagers (Closed)

Created:
4 years, 7 months ago by sky
Modified:
4 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wires up shelf to panel and dock layoutmanagers Also, fixes bug in window lookup. BUG=614362 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/37956484790decbd9acd9b2fd91f7cf592f54344 Cr-Commit-Position: refs/heads/master@{#395647}

Patch Set 1 #

Total comments: 4

Patch Set 2 : feedback #

Patch Set 3 : moar #

Total comments: 2

Patch Set 4 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -24 lines) Patch
M ash/wm/common/dock/docked_window_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/example/window_type_launcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M mash/wm/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M mash/wm/bridge/wm_root_window_controller_mus.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mash/wm/root_window_controller.h View 3 chunks +6 lines, -1 line 0 comments Download
M mash/wm/root_window_controller.cc View 2 chunks +15 lines, -1 line 0 comments Download
M mash/wm/shelf_layout_manager.h View 2 chunks +5 lines, -1 line 0 comments Download
M mash/wm/shelf_layout_manager.cc View 3 chunks +25 lines, -17 lines 0 comments Download
A mash/wm/shelf_layout_manager_delegate.h View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
M mash/wm/window_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
sky
4 years, 7 months ago (2016-05-24 13:30:01 UTC) #1
James Cook
https://codereview.chromium.org/2010473003/diff/1/mash/example/window_type_launcher/window_type_launcher.cc File mash/example/window_type_launcher/window_type_launcher.cc (right): https://codereview.chromium.org/2010473003/diff/1/mash/example/window_type_launcher/window_type_launcher.cc#newcode63 mash/example/window_type_launcher/window_type_launcher.cc:63: if ((traits & PANEL) == PANEL) { nit: maybe ...
4 years, 7 months ago (2016-05-24 15:41:04 UTC) #2
sky
https://codereview.chromium.org/2010473003/diff/1/mash/example/window_type_launcher/window_type_launcher.cc File mash/example/window_type_launcher/window_type_launcher.cc (right): https://codereview.chromium.org/2010473003/diff/1/mash/example/window_type_launcher/window_type_launcher.cc#newcode63 mash/example/window_type_launcher/window_type_launcher.cc:63: if ((traits & PANEL) == PANEL) { On 2016/05/24 ...
4 years, 7 months ago (2016-05-24 16:19:23 UTC) #3
James Cook
LGTM
4 years, 7 months ago (2016-05-24 16:29:42 UTC) #4
James Cook
https://codereview.chromium.org/2010473003/diff/40001/mash/wm/shelf_layout_manager_delegate.h File mash/wm/shelf_layout_manager_delegate.h (right): https://codereview.chromium.org/2010473003/diff/40001/mash/wm/shelf_layout_manager_delegate.h#newcode13 mash/wm/shelf_layout_manager_delegate.h:13: virtual void OnShelfWindowAvailable() = 0; Oh, could you add ...
4 years, 7 months ago (2016-05-24 16:31:01 UTC) #5
sky
https://codereview.chromium.org/2010473003/diff/40001/mash/wm/shelf_layout_manager_delegate.h File mash/wm/shelf_layout_manager_delegate.h (right): https://codereview.chromium.org/2010473003/diff/40001/mash/wm/shelf_layout_manager_delegate.h#newcode13 mash/wm/shelf_layout_manager_delegate.h:13: virtual void OnShelfWindowAvailable() = 0; On 2016/05/24 16:31:01, James ...
4 years, 7 months ago (2016-05-24 16:47:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010473003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010473003/60001
4 years, 7 months ago (2016-05-24 16:48:56 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-24 18:37:41 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 18:40:28 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/37956484790decbd9acd9b2fd91f7cf592f54344
Cr-Commit-Position: refs/heads/master@{#395647}

Powered by Google App Engine
This is Rietveld 408576698