Wires up shelf to panel and dock layoutmanagers

Wires up shelf to panel and dock layoutmanagers

Also, fixes bug in window lookup.

BUG=614362
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/37956484790decbd9acd9b2fd91f7cf592f54344
Cr-Commit-Position: refs/heads/master@{#395647}

[James Cook, 2016-05-24 15:41:04]

https://codereview.chromium.org/2010473003/diff/1/mash/example/window_type_la...
File mash/example/window_type_launcher/window_type_launcher.cc (right):

https://codereview.chromium.org/2010473003/diff/1/mash/example/window_type_la...
mash/example/window_type_launcher/window_type_launcher.cc:63: if ((traits &
PANEL) == PANEL) {
nit: maybe != 0 to match above and below?

https://codereview.chromium.org/2010473003/diff/1/mash/wm/root_window_control...
File mash/wm/root_window_controller.h (right):

https://codereview.chromium.org/2010473003/diff/1/mash/wm/root_window_control...
mash/wm/root_window_controller.h:15: #include
"mash/wm/shelf_layout_manager_delegate.h"
The bots can't find this file, maybe you forgot to add it?

[sky, 2016-05-24 16:19:23]

https://codereview.chromium.org/2010473003/diff/1/mash/example/window_type_la...
File mash/example/window_type_launcher/window_type_launcher.cc (right):

https://codereview.chromium.org/2010473003/diff/1/mash/example/window_type_la...
mash/example/window_type_launcher/window_type_launcher.cc:63: if ((traits &
PANEL) == PANEL) {
On 2016/05/24 15:41:04, James Cook wrote:
> nit: maybe != 0 to match above and below?

Done.

https://codereview.chromium.org/2010473003/diff/1/mash/wm/root_window_control...
File mash/wm/root_window_controller.h (right):

https://codereview.chromium.org/2010473003/diff/1/mash/wm/root_window_control...
mash/wm/root_window_controller.h:15: #include
"mash/wm/shelf_layout_manager_delegate.h"
On 2016/05/24 15:41:04, James Cook wrote:
> The bots can't find this file, maybe you forgot to add it?

D'OH! Done.

[James Cook, 2016-05-24 16:29:42]

LGTM

[James Cook, 2016-05-24 16:31:01]

https://codereview.chromium.org/2010473003/diff/40001/mash/wm/shelf_layout_ma...
File mash/wm/shelf_layout_manager_delegate.h (right):

https://codereview.chromium.org/2010473003/diff/40001/mash/wm/shelf_layout_ma...
mash/wm/shelf_layout_manager_delegate.h:13: virtual void
OnShelfWindowAvailable() = 0;
Oh, could you add a line of documentation about this method?

[sky, 2016-05-24 16:47:46]

https://codereview.chromium.org/2010473003/diff/40001/mash/wm/shelf_layout_ma...
File mash/wm/shelf_layout_manager_delegate.h (right):

https://codereview.chromium.org/2010473003/diff/40001/mash/wm/shelf_layout_ma...
mash/wm/shelf_layout_manager_delegate.h:13: virtual void
OnShelfWindowAvailable() = 0;
On 2016/05/24 16:31:01, James Cook wrote:
> Oh, could you add a line of documentation about this method?

Done.

[sky, 2016-05-24 16:48:32]

The CQ bit was checked by sky@chromium.org

[sky, 2016-05-24 16:48:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2010473003/#ps60001
(title: "comment")

[commit-bot: I haz the power, 2016-05-24 16:48:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010473003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010473003/60001

[commit-bot: I haz the power, 2016-05-24 18:37:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-24 18:40:27]

Description was changed from

==========
Wires up shelf to panel and dock layoutmanagers

Also, fixes bug in window lookup.

BUG=614362
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Wires up shelf to panel and dock layoutmanagers

Also, fixes bug in window lookup.

BUG=614362
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/37956484790decbd9acd9b2fd91f7cf592f54344
Cr-Commit-Position: refs/heads/master@{#395647}
==========

[commit-bot: I haz the power, 2016-05-24 18:40:28]

Patchset 4 (id:??) landed as
https://crrev.com/37956484790decbd9acd9b2fd91f7cf592f54344
Cr-Commit-Position: refs/heads/master@{#395647}