Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2010473002: Eliminate unnecessary includes and pointless forward declarations in LayoutBlock.h (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae, szager1, wkorman
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate unnecessary includes and pointless forward declarations in LayoutBlock.h BUG=614015 TBR=eae@chromium.org,szager@chromium.org,wkorman@chromium.org Committed: https://crrev.com/5beaf794b2fd60cab0f8aaae2408d19a755b0151 Cr-Commit-Position: refs/heads/master@{#395845}

Patch Set 1 #

Patch Set 2 : Make it compile in release mode too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyRun.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-25 08:11:13 UTC) #3
mstensho (USE GERRIT)
TBRing some of the trivial ones. Hope that's okay.
4 years, 7 months ago (2016-05-25 08:11:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010473002/20001
4 years, 7 months ago (2016-05-25 08:11:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 09:47:51 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5beaf794b2fd60cab0f8aaae2408d19a755b0151 Cr-Commit-Position: refs/heads/master@{#395845}
4 years, 7 months ago (2016-05-25 09:48:50 UTC) #10
eae
4 years, 7 months ago (2016-05-25 14:57:38 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698