Update Maps pixel test.

Update Maps pixel test.

Pick up a new binary from the Maps team, and update the test
expectations for a differently-sized viewport.

It looks like the sizing of the canvas in this test is slightly
different on Android than on desktop platforms, despite the fact that a
fixed device pixel ratio is sent to the Maps test itself. Work around
this by adding a mechanism to cloud_storage_test_base's test
expectations for device-specific scale factors. The machine names are
already being passed down to the test on the bots, so this will allow
the same expectations to apply on all devices. Tested locally on a Nexus
6 and 9.

Removed the failure expectations for this test (which has now been
renamed to Maps.maps_004) on Android. The test will probably fail on the
Nexus 5 and 5X, but scale factors will be checked in for these devices
in a follow-on CL.

BUG=611932
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24
Cr-Commit-Position: refs/heads/master@{#396541}

[Ken Russell (switch to Gerrit), 2016-05-27 04:33:19]

Description was changed from

==========
Update Maps pixel test.

Pick up a new binary from the Maps team, and update the test
expectations for a differently-sized viewport.

It looks like the sizing of the canvas in this test is slightly
different on Android than on desktop platforms, despite the fact that a
fixed device pixel ratio is sent to the Maps test itself. Work around
this by adding a mechanism to cloud_storage_test_base's test
expectations for device-specific scale factors. The machine names are
already being passed down to the test on the bots, so this will allow
the same expectations to apply on all devices. Tested locally on a Nexus
6 and 9.

Removed the failure expectations for this test (which has now been
renamed to Maps.maps_004) on Android. The test will probably fail on the
Nexus 5 and 5X, but scale factors will be checked in for these devices
in a follow-on CL.

BUG=611932
==========

to

==========
Update Maps pixel test.

Pick up a new binary from the Maps team, and update the test
expectations for a differently-sized viewport.

It looks like the sizing of the canvas in this test is slightly
different on Android than on desktop platforms, despite the fact that a
fixed device pixel ratio is sent to the Maps test itself. Work around
this by adding a mechanism to cloud_storage_test_base's test
expectations for device-specific scale factors. The machine names are
already being passed down to the test on the bots, so this will allow
the same expectations to apply on all devices. Tested locally on a Nexus
6 and 9.

Removed the failure expectations for this test (which has now been
renamed to Maps.maps_004) on Android. The test will probably fail on the
Nexus 5 and 5X, but scale factors will be checked in for these devices
in a follow-on CL.

BUG=611932
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-05-27 04:35:53]

kbr@chromium.org changed reviewers:
+ aiolos@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-05-27 04:35:53]

zmo: please review content/test/gpu/

aiolos: please review tools/perf/

cblume: FYI

[Zhenyao Mo, 2016-05-27 12:55:38]

content/test/gpu lgtm

really great that this pass on Android.

[aiolos (Not reviewing), 2016-05-27 17:35:51]

lgtm

https://codereview.chromium.org/2010363002/diff/1/content/test/gpu/gpu_tests/...
File content/test/gpu/gpu_tests/maps.py (right):

https://codereview.chromium.org/2010363002/diff/1/content/test/gpu/gpu_tests/...
content/test/gpu/gpu_tests/maps.py:97: # Then the maps_???.wpr.sha1 and
maps.json were copied from
I'd suggest adding this comment to the pageset.

[Ken Russell (switch to Gerrit), 2016-05-27 18:23:49]

https://codereview.chromium.org/2010363002/diff/1/content/test/gpu/gpu_tests/...
File content/test/gpu/gpu_tests/maps.py (right):

https://codereview.chromium.org/2010363002/diff/1/content/test/gpu/gpu_tests/...
content/test/gpu/gpu_tests/maps.py:97: # Then the maps_???.wpr.sha1 and
maps.json were copied from
On 2016/05/27 17:35:51, aiolos wrote:
> I'd suggest adding this comment to the pageset.

Done.

[Ken Russell (switch to Gerrit), 2016-05-27 18:24:15]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-05-27 18:24:15]

The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org,
zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2010363002/#ps60001
(title: "Remove debugging prints from presubmit script.")

[commit-bot: I haz the power, 2016-05-27 18:24:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010363002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010363002/60001

[commit-bot: I haz the power, 2016-05-27 19:55:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-27 19:57:45]

Description was changed from

==========
Update Maps pixel test.

Pick up a new binary from the Maps team, and update the test
expectations for a differently-sized viewport.

It looks like the sizing of the canvas in this test is slightly
different on Android than on desktop platforms, despite the fact that a
fixed device pixel ratio is sent to the Maps test itself. Work around
this by adding a mechanism to cloud_storage_test_base's test
expectations for device-specific scale factors. The machine names are
already being passed down to the test on the bots, so this will allow
the same expectations to apply on all devices. Tested locally on a Nexus
6 and 9.

Removed the failure expectations for this test (which has now been
renamed to Maps.maps_004) on Android. The test will probably fail on the
Nexus 5 and 5X, but scale factors will be checked in for these devices
in a follow-on CL.

BUG=611932
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Update Maps pixel test.

Pick up a new binary from the Maps team, and update the test
expectations for a differently-sized viewport.

It looks like the sizing of the canvas in this test is slightly
different on Android than on desktop platforms, despite the fact that a
fixed device pixel ratio is sent to the Maps test itself. Work around
this by adding a mechanism to cloud_storage_test_base's test
expectations for device-specific scale factors. The machine names are
already being passed down to the test on the bots, so this will allow
the same expectations to apply on all devices. Tested locally on a Nexus
6 and 9.

Removed the failure expectations for this test (which has now been
renamed to Maps.maps_004) on Android. The test will probably fail on the
Nexus 5 and 5X, but scale factors will be checked in for these devices
in a follow-on CL.

BUG=611932
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24
Cr-Commit-Position: refs/heads/master@{#396541}
==========

[commit-bot: I haz the power, 2016-05-27 19:57:46]

Patchset 4 (id:??) landed as
https://crrev.com/c329cfaedf7a947ea84e31e90c9112f4d64c3e24
Cr-Commit-Position: refs/heads/master@{#396541}