Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2010353002: Revert of Roll PDFium 490d612..54ab234 (Closed)

Created:
4 years, 6 months ago by ynovikov
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Oliver Chang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll PDFium 490d612..54ab234 (patchset #1 id:1 of https://codereview.chromium.org/2016163002/ ) Reason for revert: Looks like this breaks compilation on Win and Win x64. Original issue's description: > Roll PDFium 490d612..54ab234 > > https://pdfium.googlesource.com/pdfium.git/+log/490d612..54ab234 > TBR=ochang@chromium.org > > Committed: https://crrev.com/bfc88b40023d83d3c58e960c2986a1a76979daf6 > Cr-Commit-Position: refs/heads/master@{#396368} TBR=ochang@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/e64ac98853c5fa441b13aa4051d6d0563eca060c Cr-Commit-Position: refs/heads/master@{#396374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
ynovikov
Created Revert of Roll PDFium 490d612..54ab234
4 years, 6 months ago (2016-05-27 03:34:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010353002/1
4 years, 6 months ago (2016-05-27 03:35:08 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-05-27 03:35:10 UTC) #4
Lei Zhang
lgtm
4 years, 6 months ago (2016-05-27 03:36:27 UTC) #6
Lei Zhang
Weird, it passes try bots. Will fix and roll again.
4 years, 6 months ago (2016-05-27 03:36:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010353002/1
4 years, 6 months ago (2016-05-27 03:36:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 03:37:19 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 03:38:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e64ac98853c5fa441b13aa4051d6d0563eca060c
Cr-Commit-Position: refs/heads/master@{#396374}

Powered by Google App Engine
This is Rietveld 408576698