Issue 201035: Add some trace-points to HttpCache for request profiling (cache entry "open",...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201035: Add some trace-points to HttpCache for request profiling (cache entry "open",... (Closed)

Created:
11 years, 3 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, willchan no longer on Chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add some trace-points to HttpCache for request profiling (cache entry "open", "create", "waiting" and "read_info"). BUG=http://crbug.com/14478 TEST=HttpCache unittests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25583

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address rvargas comments #

Patch Set 3 : Sync and resolve conflict #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -13 lines)			Patch
M	net/base/load_log_event_type_list.h	View	1 2	1 chunk	+18 lines, -0 lines	0 comments	Download
M	net/http/http_cache.cc	View	1 2	5 chunks	+15 lines, -3 lines	0 comments	Download
M	net/http/http_cache_unittest.cc	View	1 2	6 chunks	+74 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

http://codereview.chromium.org/201035/diff/1/2 File net/http/http_cache_unittest.cc (right): http://codereview.chromium.org/201035/diff/1/2#newcode416 Line 416: net::LoadLog* load_log) { I would prefer to have ...

11 years, 3 months ago (2009-09-05 00:40:48 UTC) #2

eroman

11 years, 3 months ago (2009-09-05 00:58:34 UTC) #3

LGTM

Expand Messages | Collapse Messages