Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2010323002: Convert execCommand/outdent-nested-lists-*.html to use w3c test harness (Closed)

Created:
4 years, 6 months ago by yosin_UTC9
Modified:
4 years, 6 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert execCommand/outdent-nested-lists-*.html to use w3c test harness This patch introduces "outdent_nested_lists.html" as a replacement of "outdent-nested-lists-00[1-4].html" by utilizing w3c test harness with |assert_selection()| assertion, since these tests are similar pattern, to simplify test case for improving code health. This patch is a preparation of committing crrev.com/2001083002, Make FrameSelection to track associated Document. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/1410c1cd2f9a526f1e89f7fc12c2e6131e8faf3f Cr-Commit-Position: refs/heads/master@{#396768}

Patch Set 1 : 2016-05-27T11:05:16 #

Patch Set 2 : 2016-05-27T13:22:16 #

Total comments: 4

Patch Set 3 : 2016-05-31T10:35:27 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -206 lines) Patch
D third_party/WebKit/LayoutTests/editing/execCommand/outdent-nested-lists-1.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/outdent-nested-lists-1-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/outdent-nested-lists-2.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/outdent-nested-lists-2-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/outdent-nested-lists-3.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/outdent-nested-lists-3-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/outdent-nested-lists-4.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/execCommand/outdent-nested-lists-4-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html View 1 2 1 chunk +87 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/outdent-nested-lists-4-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
yosin_UTC9
PTAL
4 years, 6 months ago (2016-05-27 04:54:02 UTC) #3
yoichio
https://codereview.chromium.org/2010323002/diff/20001/third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html File third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html (right): https://codereview.chromium.org/2010323002/diff/20001/third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html#newcode9 third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html:9: '<ol contenteditable><li>one</li><ol><li>two</li></ol><li>^three|</li><li>four</li></ol>', |<ol><li>two</li></ol><li>^three|</li>| should be |<ol><li>two</li><li>^three|</li></ol>| ? https://codereview.chromium.org/2010323002/diff/20001/third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html#newcode11 third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html:11: ...
4 years, 6 months ago (2016-05-30 02:30:50 UTC) #5
yosin_UTC9
PTAL Indentation helps me to help bugs... https://codereview.chromium.org/2010323002/diff/20001/third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html File third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html (right): https://codereview.chromium.org/2010323002/diff/20001/third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html#newcode9 third_party/WebKit/LayoutTests/editing/execCommand/outdent/outdent_nested_lists.html:9: '<ol contenteditable><li>one</li><ol><li>two</li></ol><li>^three|</li><li>four</li></ol>', ...
4 years, 6 months ago (2016-05-31 01:42:32 UTC) #6
yoichio
lgtm
4 years, 6 months ago (2016-05-31 01:50:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010323002/40001
4 years, 6 months ago (2016-05-31 01:54:47 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-31 02:37:23 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 02:38:46 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1410c1cd2f9a526f1e89f7fc12c2e6131e8faf3f
Cr-Commit-Position: refs/heads/master@{#396768}

Powered by Google App Engine
This is Rietveld 408576698