Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2010293002:
[MD settings] change section title color (Closed)
|
Created:
4 years, 7 months ago by dschuyler Modified:
4 years, 6 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] change section title color
This CL changes the color of the title text in the content area
of the MD settings pages.
BUG=614592
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/e119c4d25218e988a88fcc01362d30e10b1b6ec2
Cr-Commit-Position: refs/heads/master@{#396589}
Patch Set 1 #
Total comments: 2
Patch Set 2 : color fix #Messages
Total messages: 20 (10 generated)
Description was changed from ========== [MD settings] change section title color This tiny CL changes the color of the title text in the content area of the MD settings pages. BUG=614592 ========== to ========== [MD settings] change section title color This tiny CL changes the color of the title text in the content area of the MD settings pages. BUG=614592 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MD settings] change section title color This tiny CL changes the color of the title text in the content area of the MD settings pages. BUG=614592 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] change section title color This CL changes the color of the title text in the content area of the MD settings pages. BUG=614592 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
dschuyler@chromium.org changed reviewers: + hcarmona@chromium.org
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
https://codereview.chromium.org/2010293002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/settings_section.html (right): https://codereview.chromium.org/2010293002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_section.html:19: color: var(--google-grey-600); this doesn't exist
hcarmona@chromium.org changed reviewers: - dbeam@chromium.org
lgtm
https://codereview.chromium.org/2010293002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_page/settings_section.html (right): https://codereview.chromium.org/2010293002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_page/settings_section.html:19: color: var(--google-grey-600); On 2016/05/26 23:23:58, Dan Beam wrote: > this doesn't exist Done.
On 2016/05/26 23:24:01, Hector Carmona wrote: > lgtm FWIW: Please keep in mind HTML/CSS are not syntax checked, type checked, etc. You could have your cat run across the keyboard, and the bots still might not catch it. So * If you make a change, please visually inspect the change actually takes. * If you use a variable or expression that's unfamiliar, please check (cs is your friend) if it actually exists * The above point holds for reviewers as well - please double check anything that looks the *slightest* bit unfamiliar. We have code reviews to catch these things, of course: So yay, the system is working. But it'd be nice if we could spot trivial errors before Dan takes a look. He's a great compiler/code checker, but I haven't figured out how to parallelize him yet.
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
lgtm (P.S. don't listen to Alan, he's done this a couple times)
fwiw, I google every color keyword because gray vs grey and such
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from hcarmona@chromium.org Link to the patchset: https://codereview.chromium.org/2010293002/#ps20001 (title: "color fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010293002/20001
Message was sent while issue was closed.
Description was changed from ========== [MD settings] change section title color This CL changes the color of the title text in the content area of the MD settings pages. BUG=614592 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] change section title color This CL changes the color of the title text in the content area of the MD settings pages. BUG=614592 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] change section title color This CL changes the color of the title text in the content area of the MD settings pages. BUG=614592 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] change section title color This CL changes the color of the title text in the content area of the MD settings pages. BUG=614592 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e119c4d25218e988a88fcc01362d30e10b1b6ec2 Cr-Commit-Position: refs/heads/master@{#396589} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e119c4d25218e988a88fcc01362d30e10b1b6ec2 Cr-Commit-Position: refs/heads/master@{#396589} |
