Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: shell/android/native_viewport_application_loader.h

Issue 2010283006: Almost done: ApplicationDelegate -> ApplicationImplBase conversion. (Closed) Base URL: https://github.com/domokit/mojo.git@work798-x-work797-x-work796_no_run_main_app
Patch Set: rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/android/android_handler_loader.cc ('k') | shell/android/native_viewport_application_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/android/native_viewport_application_loader.h
diff --git a/shell/android/native_viewport_application_loader.h b/shell/android/native_viewport_application_loader.h
index 1087848c4d5c26b4440741c531ccce0a162a0d87..1afc3f8b5afc66a50a0c66c99c7d3cfa5cc9832d 100644
--- a/shell/android/native_viewport_application_loader.h
+++ b/shell/android/native_viewport_application_loader.h
@@ -5,7 +5,7 @@
#ifndef MOJO_SHELL_ANDROID_NATIVE_VIEWPORT_APPLICATION_LOADER_H_
#define MOJO_SHELL_ANDROID_NATIVE_VIEWPORT_APPLICATION_LOADER_H_
-#include "mojo/public/cpp/application/application_delegate.h"
+#include "mojo/public/cpp/application/application_impl_base.h"
#include "mojo/services/gpu/interfaces/gpu.mojom.h"
#include "mojo/services/native_viewport/interfaces/native_viewport.mojom.h"
#include "services/gles2/gpu_impl.h"
@@ -15,14 +15,10 @@ namespace gles2 {
class GpuState;
}
-namespace mojo {
-class ApplicationImpl;
-} // namespace mojo
-
namespace shell {
class NativeViewportApplicationLoader : public ApplicationLoader,
- public mojo::ApplicationDelegate {
+ public mojo::ApplicationImplBase {
public:
NativeViewportApplicationLoader();
~NativeViewportApplicationLoader();
@@ -33,12 +29,11 @@ class NativeViewportApplicationLoader : public ApplicationLoader,
const GURL& url,
mojo::InterfaceRequest<mojo::Application> application_request) override;
- // mojo::ApplicationDelegate implementation.
- bool ConfigureIncomingConnection(
+ // mojo::ApplicationImplBase override.
+ bool OnAcceptConnection(
mojo::ServiceProviderImpl* service_provider_impl) override;
scoped_refptr<gles2::GpuState> gpu_state_;
- scoped_ptr<mojo::ApplicationImpl> app_;
DISALLOW_COPY_AND_ASSIGN(NativeViewportApplicationLoader);
};
« no previous file with comments | « shell/android/android_handler_loader.cc ('k') | shell/android/native_viewport_application_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698