Fix capturing variables in optimized compilations

Fix capturing variables in optimized compilations

Fourth(!) attempt. This CL fixes another instance where parsing a nested function modifies the parser state of the function that is being compiled.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.



BUG=26453
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/7daa2a8915af72ba9394fada91cb40402bff2624

[hausner, 2016-05-27 16:22:36]

Description was changed from

==========
Fix capturing variables in optimized compilations



wip


wip


wip

BUG=
==========

to

==========
Fix capturing variables in optimized compilations

Fourth(!) attempt. This CL fixes another instance where parsing a nested
function modifies the parser state of the function that is being compiled.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.



BUG=
==========

[hausner, 2016-05-27 16:22:36]

hausner@google.com changed reviewers:
+ rmacnak@google.com

[hausner, 2016-05-27 16:27:57]

Description was changed from

==========
Fix capturing variables in optimized compilations

Fourth(!) attempt. This CL fixes another instance where parsing a nested
function modifies the parser state of the function that is being compiled.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.



BUG=
==========

to

==========
Fix capturing variables in optimized compilations

Fourth(!) attempt. This CL fixes another instance where parsing a nested
function modifies the parser state of the function that is being compiled.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.



BUG= 26453
==========

[rmacnak, 2016-05-27 18:21:00]

lgtm

[hausner, 2016-05-27 18:27:13]

Description was changed from

==========
Fix capturing variables in optimized compilations

Fourth(!) attempt. This CL fixes another instance where parsing a nested
function modifies the parser state of the function that is being compiled.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.



BUG= 26453
==========

to

==========
Fix capturing variables in optimized compilations

Fourth(!) attempt. This CL fixes another instance where parsing a nested
function modifies the parser state of the function that is being compiled.

When a local function gets compiled the second time, constant
expressions may not be parsed again, since the constant value
is found in the cache. If the expression refers to an outer
variable, it does not get captured correctly.

Fix: instead of parsing a local function repeatedly to capture
outer variables, use the local function’s context scope to mark
outer variables as captured. This fixes the bug, and makes the
compiler more efficient as well.



BUG= 26453
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7daa2a8915af72ba9394fada91cb40402bff2624
==========

[hausner, 2016-05-27 18:27:15]

Committed patchset #3 (id:40001) manually as
7daa2a8915af72ba9394fada91cb40402bff2624 (presubmit successful).

[Florian Schneider, 2016-05-30 11:57:51]

fschneider@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-05-30 11:57:51]

Out of curiosity: What was the missing piece to make this fix work?