Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2010283003:
[MD settings] google-grey to paper-grey (Closed)
|
Created:
4 years, 6 months ago by dschuyler Modified:
4 years, 6 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] google-grey to paper-grey
This CL replaces some uses of the non-existent
--google-grey-600 with --paper-grey-600
BUG=589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/38ed4344f41b679538015ad40ca2c7288cc9b0ca
Cr-Commit-Position: refs/heads/master@{#398150}
Patch Set 1 #Patch Set 2 : fix colors #Patch Set 3 : merge with master #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== [MD settings] google-grey to paper-grey [MD settings] change section title color BUG= ========== to ========== [MD settings] google-grey to paper-grey [MD settings] change section title color BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== [MD settings] google-grey to paper-grey [MD settings] change section title color BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] google-grey to paper-grey This CL replaces some uses of the non-existent --google-grey-600 with --paper-grey-600 BUG=589630 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
dschuyler@chromium.org changed reviewers: + dbeam@chromium.org
dbeam@chromium.org changed reviewers: + hcarmona@chromium.org, mahmadi@chromium.org
lgtm but you may want to let hcarmona@/mahmadi@ chime in
On 2016/05/27 00:02:15, Dan Beam wrote: > lgtm but you may want to let hcarmona@/mahmadi@ chime in lgtm for passwords_shared_css.html Should we stop using google-grey-* to avoid this in the future? Looks like google-grey is just a subset of paper-grey.
On 2016/05/27 00:28:41, Hector Carmona wrote: > On 2016/05/27 00:02:15, Dan Beam wrote: > > lgtm but you may want to let hcarmona@/mahmadi@ chime in > > lgtm for passwords_shared_css.html > > Should we stop using google-grey-* to avoid this in the future? > Looks like google-grey is just a subset of paper-grey. We will be using paper-grey instead of google-grey, but it is due to Alan's request. They misleadingly look like a subset, but actually are not, sadly. Per Alan, we are going to use google- colors for non-grey colors and paper- for grey values.
On 2016/06/01 01:10:56, dschuyler wrote: > On 2016/05/27 00:28:41, Hector Carmona wrote: > > On 2016/05/27 00:02:15, Dan Beam wrote: > > > lgtm but you may want to let hcarmona@/mahmadi@ chime in > > > > lgtm for passwords_shared_css.html > > > > Should we stop using google-grey-* to avoid this in the future? > > Looks like google-grey is just a subset of paper-grey. > > We will be using paper-grey instead of google-grey, but it is > due to Alan's request. They misleadingly look like a subset, > but actually are not, sadly. Per Alan, we are going to use > google- colors for non-grey colors and paper- for grey values. Ping for Moe.
On 2016/06/01 21:29:13, dschuyler wrote: > On 2016/06/01 01:10:56, dschuyler wrote: > > On 2016/05/27 00:28:41, Hector Carmona wrote: > > > On 2016/05/27 00:02:15, Dan Beam wrote: > > > > lgtm but you may want to let hcarmona@/mahmadi@ chime in > > > > > > lgtm for passwords_shared_css.html > > > > > > Should we stop using google-grey-* to avoid this in the future? > > > Looks like google-grey is just a subset of paper-grey. > > > > We will be using paper-grey instead of google-grey, but it is > > due to Alan's request. They misleadingly look like a subset, > > but actually are not, sadly. Per Alan, we are going to use > > google- colors for non-grey colors and paper- for grey values. > > Ping for Moe. Thanks for the ping. I got user_manager_tutorial fixed in https://codereview.chromium.org/2016073002
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010283003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010283003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org, hcarmona@chromium.org Link to the patchset: https://codereview.chromium.org/2010283003/#ps40001 (title: "merge with master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010283003/40001
Message was sent while issue was closed.
Description was changed from ========== [MD settings] google-grey to paper-grey This CL replaces some uses of the non-existent --google-grey-600 with --paper-grey-600 BUG=589630 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] google-grey to paper-grey This CL replaces some uses of the non-existent --google-grey-600 with --paper-grey-600 BUG=589630 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] google-grey to paper-grey This CL replaces some uses of the non-existent --google-grey-600 with --paper-grey-600 BUG=589630 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] google-grey to paper-grey This CL replaces some uses of the non-existent --google-grey-600 with --paper-grey-600 BUG=589630 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/38ed4344f41b679538015ad40ca2c7288cc9b0ca Cr-Commit-Position: refs/heads/master@{#398150} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/38ed4344f41b679538015ad40ca2c7288cc9b0ca Cr-Commit-Position: refs/heads/master@{#398150} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
