Add YieldStatement support to ExitDetector

Add YieldStatement support to ExitDetector

BUG=https://github.com/dart-lang/sdk/issues/26553
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/c2794f634aed98d40ef9434d1fdf89cfefe5065a

[srawlins, 2016-05-26 23:12:21]

srawlins@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[srawlins, 2016-05-26 23:12:21]

Working our way towards a more perfect ExitDetector

[Brian Wilkerson, 2016-05-27 14:26:02]

I don't understand the thinking here. The yield statement does not cause the
method to terminate, it (potentially) causes the method to be suspended until
the next invocation of `moveNext` on the iterator obtained from the returned
iteratable. When the method resumes it will resume with the statement
immediately following the yield. What am I missing?

[srawlins, 2016-05-27 16:39:19]

On 2016/05/27 14:26:02, Brian Wilkerson wrote:
> I don't understand the thinking here. The yield statement does not cause the
> method to terminate, it (potentially) causes the method to be suspended until
> the next invocation of `moveNext` on the iterator obtained from the returned
> iteratable. When the method resumes it will resume with the statement
> immediately following the yield. What am I missing?

Unless it throws or something, right?

https://dartpad.dartlang.org/16b88336f258255076501c81620554b7

[Brian Wilkerson, 2016-05-27 18:24:36]

Yes, but then it's because of the throw, not because of the yield.

[Brian Wilkerson, 2016-05-27 18:26:34]

Sorry! I didn't understand what I was looking at the first time. You're
absolutely right. LGTM.

[srawlins, 2016-05-27 18:44:08]

Description was changed from

==========
Add YieldStatement support to ExitDetector

BUG=https://github.com/dart-lang/sdk/issues/26553
==========

to

==========
Add YieldStatement support to ExitDetector

BUG=https://github.com/dart-lang/sdk/issues/26553
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c2794f634aed98d40ef9434d1fdf89cfefe5065a
==========

[srawlins, 2016-05-27 18:44:10]

Committed patchset #1 (id:1) manually as
c2794f634aed98d40ef9434d1fdf89cfefe5065a (presubmit successful).