Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc

Issue 2010253003: Sending a data saver Pageload metrics pingback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc
index 335ceecdfa5082208672fe0845214144a4df0b7f..e305178b5df51e1ad1988c5fb15a7da9ace9e8ee 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_data_unittest.cc
@@ -5,20 +5,21 @@
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_data.h"
#include <memory>
#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "net/base/request_priority.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_context.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
namespace data_reduction_proxy {
namespace {
class DataReductionProxyDataTest : public testing::Test {
public:
DataReductionProxyDataTest() {}
private:
@@ -31,20 +32,29 @@ TEST_F(DataReductionProxyDataTest, BasicSettersAndGetters) {
data->set_used_data_reduction_proxy(true);
EXPECT_TRUE(data->used_data_reduction_proxy());
data->set_used_data_reduction_proxy(false);
EXPECT_FALSE(data->used_data_reduction_proxy());
EXPECT_FALSE(data->lofi_requested());
data->set_lofi_requested(true);
EXPECT_TRUE(data->lofi_requested());
data->set_lofi_requested(false);
EXPECT_FALSE(data->lofi_requested());
+
+ EXPECT_EQ(std::string(), data->session_key());
+ EXPECT_EQ(GURL(std::string()), data->original_request_url());
+ std::string session_key = "test-key";
+ data->set_session_key(session_key);
+ EXPECT_EQ(session_key, data->session_key());
+ GURL test_url("test-url");
+ data->set_original_request_url(test_url);
+ EXPECT_EQ(test_url, data->original_request_url());
}
TEST_F(DataReductionProxyDataTest, AddToURLRequest) {
std::unique_ptr<net::URLRequestContext> context(new net::URLRequestContext());
std::unique_ptr<net::URLRequest> fake_request(context->CreateRequest(
GURL("http://www.google.com"), net::RequestPriority::IDLE, nullptr));
DataReductionProxyData* data =
DataReductionProxyData::GetData(*fake_request.get());
EXPECT_TRUE(!data);
data =
@@ -70,22 +80,28 @@ TEST_F(DataReductionProxyDataTest, DeepCopy) {
},
{
true, false,
},
{
true, true,
},
};
for (size_t i = 0; i < arraysize(tests); ++i) {
+ static const char kSessionKey[] = "test-key";
+ static const GURL kTestURL("test-url");
std::unique_ptr<DataReductionProxyData> data(new DataReductionProxyData());
data->set_used_data_reduction_proxy(tests[i].data_reduction_used);
data->set_lofi_requested(tests[i].lofi_on);
+ data->set_session_key(kSessionKey);
+ data->set_original_request_url(kTestURL);
std::unique_ptr<DataReductionProxyData> copy = data->DeepCopy();
EXPECT_EQ(tests[i].lofi_on, copy->lofi_requested());
EXPECT_EQ(tests[i].data_reduction_used, copy->used_data_reduction_proxy());
+ EXPECT_EQ(kSessionKey, copy->session_key());
+ EXPECT_EQ(kTestURL, copy->original_request_url());
}
}
} // namespace
} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698