Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h

Issue 2010253003: Sending a data saver Pageload metrics pingback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
index dcaa6d37184e4c043aad7025c61479a66fa23850..5747e5a9daf050711490496643182a603c0afe24 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
@@ -1,30 +1,35 @@
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_
#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_
+#include <memory>
+
#include "base/macros.h"
#include "components/page_load_metrics/browser/page_load_metrics_observer.h"
namespace content {
+class BrowserContext;
class NavigationHandle;
}
namespace page_load_metrics {
struct PageLoadExtraInfo;
struct PageLoadTiming;
}
namespace data_reduction_proxy {
+class DataReductionProxyData;
+class DataReductionProxyPingbackClient;
namespace internal {
// Various UMA histogram names for DataReductionProxy core page load metrics.
extern const char kHistogramFirstContentfulPaintDataReductionProxy[];
extern const char kHistogramFirstContentfulPaintDataReductionProxyLoFiOn[];
} // namespace internal
// Observer responsible for recording core page load metrics releveant to
@@ -33,24 +38,29 @@ class DataReductionProxyMetricsObserver
: public page_load_metrics::PageLoadMetricsObserver {
public:
DataReductionProxyMetricsObserver();
~DataReductionProxyMetricsObserver() override;
// page_load_metrics::PageLoadMetricsObserver:
void OnCommit(content::NavigationHandle* navigation_handle) override;
void OnFirstContentfulPaint(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& info) override;
+ void OnComplete(const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& info) override;
private:
- // True if the navigation requested LoFi.
- bool lofi_requested_;
+ // Gets the default DataReductionProxyPingbackClient. Overridden in testing.
+ virtual DataReductionProxyPingbackClient* GetPingbackClient() const;
+
+ // Data related to this navigation.
+ std::unique_ptr<DataReductionProxyData> data_;
- // True if the navigation was proxied through the data reduction proxy.
- bool used_data_reduction_proxy_;
+ // The browser context this navigation is operating in.
+ content::BrowserContext* browser_context_;
DISALLOW_COPY_AND_ASSIGN(DataReductionProxyMetricsObserver);
};
} // namespace data_reduction_proxy
#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_DATA_REDUCTION_PROXY_METRICS_OBSERVER_H_
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698