Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 20102002: free cache in destructor, in case endContext was not called. change Resize to return bool indicatin… (Closed)

Created:
7 years, 5 months ago by reed1
Modified:
7 years, 5 months ago
Reviewers:
humper
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

free cache in destructor, in case endContext was not called. change Resize to return bool indicating success. BUG= R=humper@google.com Committed: https://code.google.com/p/skia/source/detail?r=10335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -39 lines) Patch
M src/core/SkBitmapProcState.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 2 chunks +18 lines, -5 lines 0 comments Download
M src/core/SkBitmapScaler.h View 1 chunk +13 lines, -11 lines 0 comments Download
M src/core/SkBitmapScaler.cpp View 5 chunks +26 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
7 years, 5 months ago (2013-07-24 19:34:25 UTC) #1
humper
On 2013/07/24 19:34:25, reed1 wrote: lgtm
7 years, 5 months ago (2013-07-24 19:51:57 UTC) #2
reed1
7 years, 5 months ago (2013-07-24 20:10:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r10335 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698