Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2010183003: [runtime] Kill the %NumberToIntegerMapMinusZero runtime entry. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Kill the %NumberToIntegerMapMinusZero runtime entry. This was initially used to special case some weird date.js behavior, but has since been abused in other areas. In case of the string character access, everything that is outside the Smi range cannot be a valid string index anyways, so %NumberToSmi is perfect here in either case, and for ToPositiveInteger it's better to just use ToInteger adding +0 to turn -0 into +0. R=ishell@chromium.org BUG=v8:5049 Committed: https://crrev.com/4b235adecc6edaf9f02c0fe9b34762a0f5ae937b Cr-Commit-Position: refs/heads/master@{#36545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -170 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M src/code-stubs.h View 5 chunks +1 line, -16 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/js/macros.py View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/runtime.js View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-numbers.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 6 months ago (2016-05-27 11:08:29 UTC) #1
Benedikt Meurer
Hey Igor, Some cleanup on the runtime entries. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-05-27 11:08:56 UTC) #2
Igor Sheludko
lgtm
4 years, 6 months ago (2016-05-27 11:31:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010183003/1
4 years, 6 months ago (2016-05-27 11:31:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 11:50:02 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 11:52:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b235adecc6edaf9f02c0fe9b34762a0f5ae937b
Cr-Commit-Position: refs/heads/master@{#36545}

Powered by Google App Engine
This is Rietveld 408576698