base/metrics/persistent_histogram_allocator.h - Issue 2010173005: Support experiment to store persistent metrics in memory-mapped file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/persistent_histogram_allocator.h

Issue 2010173005: Support experiment to store persistent metrics in memory-mapped file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moved file cleanup to anonymous function Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/persistent_histogram_allocator.h

diff --git a/base/metrics/persistent_histogram_allocator.h b/base/metrics/persistent_histogram_allocator.h

index 5464da6a573148a7096870f1835af1d7f349c0e5..a89197031fb78cf073561abc9aedf06945469592 100644

--- a/base/metrics/persistent_histogram_allocator.h

+++ b/base/metrics/persistent_histogram_allocator.h

@@ -439,6 +439,10 @@ class BASE_EXPORT GlobalHistogramAllocator

// in order to persist the data for a later use.

void SetPersistentLocation(const FilePath& location);

+ // Retrieves a previously set pathname to which the contents of this allocator

+ // are to be saved.

+ const FilePath& GetPersistentLocation();

Ilya Sherman 2016/06/17 19:54:32 nit: Can the method be marked as const as well?

bcwhite 2016/06/20 16:21:28 Done.

// Writes the internal data to a previously set location. This is generally

// called when a process is exiting from a section of code that may not know

// the filesystem. The data is written in an atomic manner. The return value

« no previous file with comments | « no previous file | base/metrics/persistent_histogram_allocator.cc » ('j') | chrome/browser/chrome_browser_field_trials.cc » ('J')