Fix lint error on int def in BidirectionalStream.java

Fix lint error on int def in BidirectionalStream.java

BUG=615045

[xunjieli, 2016-05-26 18:54:01]

xunjieli@chromium.org changed reviewers:
+ pauljensen@chromium.org

[xunjieli, 2016-05-26 18:54:01]

Hi Paul, I am not sure why lint would complain about the IntDef, see the crbug
for more information. My guess is that lint isn't smart enough to understand
that  createBidirectionalStream is invoked with the correct constant in
BidirectionalStream.java. But I don't really know ..

[pauljensen, 2016-05-27 11:44:13]

Hmm.  Weird.  I spent some time just now trying to get this to work with no
luck.  I don't think we should remove the annotation if it's correct but lint is
broken.
I see crbug.com/605296 is very similar.
Perhaps there is a lint bug, e.g.
https://code.google.com/p/android/issues/detail?id=182179
Anyhow, how about adding back in the annotation, and also adding the
corresponding one for createRequest() and then adding
@SuppressLint("WrongConstant") at the call site sorta like jbudorick@ did in
this CL:
https://codereview.chromium.org/1910343005
although more targeted.

I think we should also rope in jbudorick@ and ask him if he can debug lint to
see what's wrong.  I don't think we want to be painting the codebase in
suppressions due to a broken tool, or more likely I'm guessing, an incorrectly
invoked tool.  Does this fail with gyp?

[xunjieli, 2016-05-27 13:23:46]

On 2016/05/27 11:44:13, pauljensen wrote:
> Hmm.  Weird.  I spent some time just now trying to get this to work with no
> luck.  I don't think we should remove the annotation if it's correct but lint
is
> broken.
> I see crbug.com/605296 is very similar.
> Perhaps there is a lint bug, e.g.
> https://code.google.com/p/android/issues/detail?id=182179
> Anyhow, how about adding back in the annotation, and also adding the
> corresponding one for createRequest() and then adding
> @SuppressLint("WrongConstant") at the call site sorta like jbudorick@ did in
> this CL:
> https://codereview.chromium.org/1910343005
> although more targeted.
> 
> I think we should also rope in jbudorick@ and ask him if he can debug lint to
> see what's wrong.  I don't think we want to be painting the codebase in
> suppressions due to a broken tool, or more likely I'm guessing, an incorrectly
> invoked tool.  Does this fail with gyp?

Hi Paul, this is very helpful! Thanks for digging into this. I just tried gyp,
and gyp doesn't produce this warning. This might be gn related. I will loop in
jbudorick@ and see if this is because of the lint tool. Thanks again!

[xunjieli, 2016-05-31 17:59:16]

Description was changed from

==========
Fix lint error on int def in BidirectionalStream.java

BUG=615045
==========

to

==========
Fix lint error on int def in BidirectionalStream.java

BUG=615045
==========