Issue 20101007: Don't use WebURL as a std::map key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20101007: Don't use WebURL as a std::map key (Closed)

Created:
7 years, 5 months ago by abarth-chromium

Modified:
7 years, 5 months ago

Reviewers:
jamesr

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't use WebURL as a std::map key I'm removing the operator< for WebURL in https://codereview.chromium.org/20135002/. Instead of using WebURL as a map key, we should just use GURL. GURL knows how to play nice with STL containers. R=jamesr@chromium.org BUG=261412 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213663

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	webkit/support/weburl_loader_mock_factory.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/20101007/1

7 years, 5 months ago (2013-07-24 23:23:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/20101007/1

7 years, 5 months ago (2013-07-25 14:20:42 UTC) #4

abarth-chromium

7 years, 5 months ago (2013-07-25 18:34:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r213663 (presubmit successful).