Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: net/quic/quic_packet_creator.cc

Issue 2010043002: Add extra log when CHLO is considered not fit in one packet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@122875237
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_creator.cc
diff --git a/net/quic/quic_packet_creator.cc b/net/quic/quic_packet_creator.cc
index 26411f26dda8d84c3b1e57018a7affdb32d4cdee..d66f565817110c0cebc80f627c680abbc4ecd03f 100644
--- a/net/quic/quic_packet_creator.cc
+++ b/net/quic/quic_packet_creator.cc
@@ -174,7 +174,9 @@ bool QuicPacketCreator::ConsumeData(QuicStreamId id,
DCHECK_EQ(static_cast<size_t>(0), iov_offset);
if (frame->stream_frame->data_length < iov.iov->iov_len) {
const string error_details = "Client hello won't fit in a single packet.";
- QUIC_BUG << error_details;
+ QUIC_BUG << error_details << " Constructed stream frame length: "
+ << frame->stream_frame->data_length
+ << " CHLO length: " << iov.iov->iov_len;
delegate_->OnUnrecoverableError(QUIC_CRYPTO_CHLO_TOO_LARGE, error_details,
ConnectionCloseSource::FROM_SELF);
delete frame->stream_frame;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698