Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2010013003: Rename FXJSE_CLASS to avoid confusion with CFXJSE_CLASS (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename FXJSE_CLASS to avoid confusion with CFXJSE_CLASS BUG= Committed: https://pdfium.googlesource.com/pdfium/+/e3b2a4eca66e357df663a6f7464ef9af5e85883f

Patch Set 1 #

Patch Set 2 : rename member #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -83 lines) Patch
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 3 chunks +9 lines, -9 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxjse/class.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxjse/class.cpp View 13 chunks +35 lines, -26 lines 0 comments Download
M xfa/fxjse/context.h View 1 chunk +5 lines, -4 lines 0 comments Download
M xfa/fxjse/context.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M xfa/fxjse/dynprop.cpp View 13 chunks +22 lines, -20 lines 0 comments Download
M xfa/fxjse/include/fxjse.h View 3 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, straight rename.
4 years, 7 months ago (2016-05-26 19:24:59 UTC) #2
dsinclair
lgtm
4 years, 7 months ago (2016-05-26 19:39:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010013003/20001
4 years, 7 months ago (2016-05-26 19:39:14 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 19:39:39 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/e3b2a4eca66e357df663a6f7464ef9af5e85...

Powered by Google App Engine
This is Rietveld 408576698