Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2010003002: Reduce the number of calls to external estimate provider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index fd51a61499febb3b757eed73700cc40ccc0149a3..734a2f311ddf6cec25f3ef0bf34e128797cae9bd 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -265,7 +265,9 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
NetworkChangeNotifier::ConnectionType type) override;
// ExternalEstimateProvider::UpdatedEstimateObserver implementation.
- void OnUpdatedEstimateAvailable() override;
+ void OnUpdatedEstimateAvailable(const base::TimeDelta& rtt,
+ int32_t downstream_throughput_kbps,
+ int32_t upstream_throughput_kbps) override;
// Return a string equivalent to |type|.
const char* GetNameForEffectiveConnectionType(
@@ -315,11 +317,6 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
// Larger size may affect performance.
static const size_t kMaximumNetworkQualityCacheSize = 10;
- // Time duration (in milliseconds) after which the estimate provided by
- // external estimate provider is considered stale.
- static const int kExternalEstimateProviderFreshnessDurationMsec =
- 5 * 60 * 1000;
-
// Returns the RTT value to be used when the valid RTT is unavailable. Readers
// should discard RTT if it is set to the value returned by |InvalidRTT()|.
static const base::TimeDelta InvalidRTT();
@@ -336,10 +333,6 @@ class NET_EXPORT_PRIVATE NetworkQualityEstimator
void OnUpdatedRTTAvailable(SocketPerformanceWatcherFactory::Protocol protocol,
const base::TimeDelta& rtt);
- // Queries the external estimate provider for the latest network quality
- // estimates, and adds those estimates to the current observation buffer.
- void QueryExternalEstimateProvider();
-
// Obtains operating parameters from the field trial parameters.
void ObtainOperatingParams(
const std::map<std::string, std::string>& variation_params);

Powered by Google App Engine
This is Rietveld 408576698