Reduce the number of calls to external estimate provider

chrome/browser/android/net/external_estimate_provider_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/net/external_estimate_provider_android.h"
 
 #include <stdint.h>
 
 #include "base/android/context_utils.h"
 #include "base/message_loop/message_loop.h"
 #include "content/public/browser/browser_thread.h"
 #include "jni/ExternalEstimateProviderAndroid_jni.h"
 
 namespace chrome {
 namespace android {
 
 ExternalEstimateProviderAndroid::ExternalEstimateProviderAndroid()
     : task_runner_(nullptr),
       delegate_(nullptr),
       weak_factory_(this) {
   if (base::MessageLoop::current())
     task_runner_ = base::MessageLoop::current()->task_runner();
   JNIEnv* env = base::android::AttachCurrentThread();
   j_external_estimate_provider_.Reset(
       Java_ExternalEstimateProviderAndroid_create(
           env, base::android::GetApplicationContext(),
           reinterpret_cast<intptr_t>(this)));
   DCHECK(!j_external_estimate_provider_.is_null());
   no_value_ = Java_ExternalEstimateProviderAndroid_getNoValue(env);
-  net::NetworkChangeNotifier::AddConnectionTypeObserver(this);
 }
 
 ExternalEstimateProviderAndroid::~ExternalEstimateProviderAndroid() {
   DCHECK(thread_checker_.CalledOnValidThread());
-  net::NetworkChangeNotifier::RemoveConnectionTypeObserver(this);
   Java_ExternalEstimateProviderAndroid_destroy(
       base::android::AttachCurrentThread(),
       j_external_estimate_provider_.obj());
 }
 
 bool ExternalEstimateProviderAndroid::GetRTT(base::TimeDelta* rtt) const {
   DCHECK(thread_checker_.CalledOnValidThread());
   JNIEnv* env = base::android::AttachCurrentThread();
   int32_t milliseconds =
       Java_ExternalEstimateProviderAndroid_getRTTMilliseconds(
@@ skipping 53 matching lines @@
   delegate_ = delegate;
 }
 
 void ExternalEstimateProviderAndroid::Update() const {
   DCHECK(thread_checker_.CalledOnValidThread());
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_ExternalEstimateProviderAndroid_requestUpdate(
       env, j_external_estimate_provider_.obj());
 }
 
-void ExternalEstimateProviderAndroid::OnConnectionTypeChanged(
-    net::NetworkChangeNotifier::ConnectionType type) {
-  Update();
-}
-
 void ExternalEstimateProviderAndroid::
     NotifyExternalEstimateProviderAndroidUpdate(
         JNIEnv* env,
         const JavaParamRef<jobject>& obj) {
   if (!task_runner_)
     return;
 
   // Note that creating a weak pointer is safe even on a background thread,
   // because this method is called from the same critical section as the Java
   // destroy() method (so this object can't be destroyed while we're in this
   // method), and the factory itself isn't bound to a thread, just the weak
   // pointers are (but they are bound to the thread they're *dereferenced* on,
   // which is the task runner thread). Once we are outside of the critical
   // section, the weak pointer will be invalidated if the object is destroyed.
   task_runner_->PostTask(
       FROM_HERE,
       base::Bind(
           &ExternalEstimateProviderAndroid::NotifyUpdatedEstimateAvailable,
           weak_factory_.GetWeakPtr()));
 }
 
 void ExternalEstimateProviderAndroid::NotifyUpdatedEstimateAvailable() const {
   DCHECK(thread_checker_.CalledOnValidThread());
-  if (delegate_)
-    delegate_->OnUpdatedEstimateAvailable();
+
+  base::TimeDelta rtt;
+  if (!GetRTT(&rtt))

[bengr, 2016/05/27 19:58:42]

Shouldn't GetRTT not modify &rtt if it returns false?

[tbansal1, 2016/05/27 23:39:14]

Done.

+    rtt = base::TimeDelta();
+
+  int32_t downstream_throughput_kbps;
+  if (!GetDownstreamThroughputKbps(&downstream_throughput_kbps))
+    downstream_throughput_kbps = -1;
+
+  int32_t upstream_throughput_kbps;
+  if (!GetUpstreamThroughputKbps(&upstream_throughput_kbps))
+    upstream_throughput_kbps = -1;
+
+  if (delegate_) {
+    delegate_->OnUpdatedEstimateAvailable(rtt, downstream_throughput_kbps,
+                                          upstream_throughput_kbps);
+  }
 }
 
 bool RegisterExternalEstimateProviderAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 }  // namespace chrome