Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2009903002: [DevTools] Stick with top frame unless user selected something else. (Closed)

Created:
4 years, 6 months ago by dgozman
Modified:
4 years, 6 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Stick with top frame unless user selected something else. BUG=613878 Committed: https://crrev.com/9ba33beabdf47d80c723b4af670df825077be80f Cr-Commit-Position: refs/heads/master@{#396058}

Patch Set 1 #

Total comments: 2

Patch Set 2 : more logic, and a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -31 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js View 1 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context.html View 1 3 chunks +57 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/last-execution-context-expected.txt View 1 1 chunk +45 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js View 1 4 chunks +59 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dgozman
Take a look please.
4 years, 6 months ago (2016-05-25 17:40:25 UTC) #2
kozy
Can we add a test? https://codereview.chromium.org/2009903002/diff/1/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js File third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js (right): https://codereview.chromium.org/2009903002/diff/1/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js#newcode135 third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js:135: this._ignoreContextChanged = true; Should ...
4 years, 6 months ago (2016-05-25 18:11:53 UTC) #3
dgozman
PTAL, much better now! https://codereview.chromium.org/2009903002/diff/1/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js File third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js (right): https://codereview.chromium.org/2009903002/diff/1/third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js#newcode135 third_party/WebKit/Source/devtools/front_end/components/ExecutionContextSelector.js:135: this._ignoreContextChanged = true; On 2016/05/25 ...
4 years, 6 months ago (2016-05-25 21:15:15 UTC) #4
kozy
lgtm
4 years, 6 months ago (2016-05-25 21:28:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009903002/20001
4 years, 6 months ago (2016-05-25 21:58:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-26 00:42:05 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 00:43:52 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9ba33beabdf47d80c723b4af670df825077be80f
Cr-Commit-Position: refs/heads/master@{#396058}

Powered by Google App Engine
This is Rietveld 408576698