tools/android/loading/sandwich_metrics_unittest.py - Issue 2009883002: sandwich: Make metrics extraction more customizable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/android/loading/sandwich_metrics_unittest.py

Issue 2009883002: sandwich: Make metrics extraction more customizable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Egor's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/android/loading/sandwich_metrics_unittest.py

diff --git a/tools/android/loading/sandwich_metrics_unittest.py b/tools/android/loading/sandwich_metrics_unittest.py

index 12ed037a4487a9c68a31ba67d79dffeb610a58a2..f401e65981bdce8ba25ae22be83ab7a4514eff44 100644

--- a/tools/android/loading/sandwich_metrics_unittest.py

+++ b/tools/android/loading/sandwich_metrics_unittest.py

@@ -232,7 +232,7 @@ class PageTrackTest(unittest.TestCase):

point(400, 1.0),

]

self.assertEqual(120 + 70 * 0.6 + 90 * 0.25,

- puller.ComputeSpeedIndex(completness_record))

+ puller._ComputeSpeedIndex(completness_record))

completness_record = [

point(70, 0.0),

@@ -242,7 +242,7 @@ class PageTrackTest(unittest.TestCase):

point(240, 1.0),

]

self.assertEqual(80 + 60 * 0.7 + 10 * 0.4 + 20 * 0.1,

- puller.ComputeSpeedIndex(completness_record))

+ puller._ComputeSpeedIndex(completness_record))

completness_record = [

point(90, 0.0),

@@ -251,7 +251,7 @@ class PageTrackTest(unittest.TestCase):

point(230, 1.0),

]

with self.assertRaises(ValueError):

- puller.ComputeSpeedIndex(completness_record)

+ puller._ComputeSpeedIndex(completness_record)

if __name__ == '__main__':

« no previous file with comments | « tools/android/loading/sandwich_metrics.py ('k') | tools/android/loading/sandwich_runner.py » ('j') | tools/android/loading/sandwich_runner.py » ('J')