sandwich: Make metrics extraction more customizable.

tools/android/loading/sandwich_runner.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import shutil
 import sys
 import tempfile
 
@@ skipping 232 matching lines @@
         for repeat_id in xrange(self.repeat):
           self._RunUrl(run_id=repeat_id)
     finally:
       if self._local_cache_directory_path:
         shutil.rmtree(self._local_cache_directory_path)
         self._local_cache_directory_path = None
     if self.cache_operation == CacheOperation.SAVE:
       self._PullCacheFromDevice()
 
     self._chrome_ctl = None
+
+
+def IterRepeatedRuns(runner_output_dir):

[pasko, 2016/05/31 13:00:33]

naming:

this is a generator, so let's call it: GenerateRepeatedRuns(...)

[gabadie, 2016/05/31 14:33:01]

WalkRepeatedRuns as agreed offline.

+  """Yields repeat_id, repeat_dir.

[pasko, 2016/05/31 13:00:33]

Let's add "Not ordered."

[pasko, 2016/05/31 13:00:33]

s/repeat_dir/repeat_directory/

[gabadie, 2016/05/31 14:33:01]

Line are not very wide and git -C tools/android/loading grep "dir\W" | wc -l ->
236

[gabadie, 2016/05/31 14:33:02]

Done.

[pasko, 2016/05/31 16:00:00]

LOL, this was about the comment that fits into the line. Not a problem for me in
either case, just adding more human language to this comment would make it a
tiny bit more like a comment.

[gabadie, 2016/06/01 12:04:33]

Oh my bad, I have not seen that this comment was actually on the doc string.
Done.

+
+  Args:
+    runner_output_dir: Same as for SandwichRunner.output_dir.
+  """
+  repeated_run_count = 0
+  for node_name in os.listdir(runner_output_dir):
+    repeat_dir = os.path.join(runner_output_dir, node_name)
+    if not os.path.isdir(repeat_dir):
+      continue
+    try:
+      repeat_id = int(node_name)
+    except ValueError:
+      continue
+    yield repeat_id, repeat_dir
+    repeated_run_count += 1
+  assert repeated_run_count > 0, ('Looks like \'{}\' was not a sandwich runner '

[pasko, 2016/05/31 13:00:33]

nit: I prefer error messages to mention the important bits of the state at the
end.

Like:
Error: not a sandwich runner output directory: {}

[gabadie, 2016/05/31 14:33:01]

Done.

+      'output directory.').format(output_directory_path)