Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2009853003: accept null type casts in dummy noSuchMethod checks (Closed)

Created:
4 years, 7 months ago by Harry Terkelsen
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

accept null type casts in dummy noSuchMethod checks Fixes #23843 R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/b5fbea4f4a6e2a093f4d39a05f0b7fc9803f974b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/no_such_method_enabled_test.dart View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 7 months ago (2016-05-25 17:08:18 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 7 months ago (2016-05-25 17:13:13 UTC) #3
Harry Terkelsen
4 years, 7 months ago (2016-05-25 17:14:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5fbea4f4a6e2a093f4d39a05f0b7fc9803f974b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698