Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2009823002: [wasm] Do not try start linking if the compilation failed. (Closed)

Created:
4 years, 7 months ago by ahaas
Modified:
4 years, 7 months ago
Reviewers:
titzer, bradnelson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Do not try start linking if the compilation failed. BUG=chromium:614291 LOG=N R=titzer@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/f768e53cd8e20fa5e24a096b9a443940d8968cf1 Cr-Commit-Position: refs/heads/master@{#36503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/wasm/wasm-module.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ahaas
4 years, 7 months ago (2016-05-25 08:53:24 UTC) #1
titzer
lgtm
4 years, 7 months ago (2016-05-25 08:56:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009823002/1
4 years, 7 months ago (2016-05-25 08:57:49 UTC) #4
bradnelson
lgtm
4 years, 7 months ago (2016-05-25 09:14:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 09:26:36 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 09:28:53 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f768e53cd8e20fa5e24a096b9a443940d8968cf1
Cr-Commit-Position: refs/heads/master@{#36503}

Powered by Google App Engine
This is Rietveld 408576698