Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2009803003: Remove default argument from RestoreState() methods. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove default argument from RestoreState() methods. Committed: https://pdfium.googlesource.com/pdfium/+/41846a0fcc7d98476a18ec6c97778ead58069d99

Patch Set 1 #

Total comments: 4

Patch Set 2 : nit, move impl to .cpp #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -80 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/agg/fx_agg_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/agg/fx_agg_driver.cpp View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M core/fxge/apple/apple_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/apple/fx_quartz_device.cpp View 17 chunks +20 lines, -18 lines 0 comments Download
M core/fxge/ge/fx_ge_device.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M core/fxge/ge/fx_ge_ps.cpp View 1 chunk +12 lines, -6 lines 0 comments Download
M core/fxge/include/fx_ge.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M core/fxge/skia/fx_skia_device.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 2 chunks +12 lines, -0 lines 0 comments Download
M core/fxge/win32/fx_win32_print.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M core/fxge/win32/win32_int.h View 1 2 chunks +3 lines, -8 lines 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_pageobjs.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListCtrl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/fde_gedevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/cfx_graphics.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
https://codereview.chromium.org/2009803003/diff/1/core/fxge/agg/fx_agg_driver.cpp File core/fxge/agg/fx_agg_driver.cpp (right): https://codereview.chromium.org/2009803003/diff/1/core/fxge/agg/fx_agg_driver.cpp#newcode288 core/fxge/agg/fx_agg_driver.cpp:288: delete m_pClipRgn; A little more cleanup here. https://codereview.chromium.org/2009803003/diff/1/core/fxge/ge/fx_ge_ps.cpp File ...
4 years, 7 months ago (2016-05-26 01:50:11 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/2009803003/diff/1/core/fxge/win32/win32_int.h File core/fxge/win32/win32_int.h (right): https://codereview.chromium.org/2009803003/diff/1/core/fxge/win32/win32_int.h#newcode115 core/fxge/win32/win32_int.h:115: if (bKeepSaved) { nit. no {}
4 years, 7 months ago (2016-05-26 16:07:48 UTC) #3
Lei Zhang
https://codereview.chromium.org/2009803003/diff/1/core/fxge/win32/win32_int.h File core/fxge/win32/win32_int.h (right): https://codereview.chromium.org/2009803003/diff/1/core/fxge/win32/win32_int.h#newcode115 core/fxge/win32/win32_int.h:115: if (bKeepSaved) { On 2016/05/26 16:07:48, Tom Sepez wrote: ...
4 years, 7 months ago (2016-05-26 17:43:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009803003/40001
4 years, 7 months ago (2016-05-26 17:43:33 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 17:45:35 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/41846a0fcc7d98476a18ec6c97778ead5806...

Powered by Google App Engine
This is Rietveld 408576698