Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2009783003: [MD settings] move root css vars; increase checkbox and h2 row-height (Closed)

Created:
4 years, 6 months ago by dschuyler
Modified:
4 years, 6 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] move root css vars; increase checkbox and h2 row-height This CL moves the :root css vars from settings_shared_css.html into a separate file that is imported in settings.html. This more clearly reflects the scope of :root vars. A height var is then used for the checkbox, radio button and h2 style. BUG=614476 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3204336053295d134ab7844403393b23cae1f057 Cr-Commit-Position: refs/heads/master@{#396285}

Patch Set 1 : changed to import #

Patch Set 2 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -45 lines) Patch
M chrome/browser/resources/settings/controls/settings_checkbox.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_dialog.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/settings_root_css.html View 1 chunk +45 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 2 chunks +3 lines, -44 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
dschuyler
4 years, 6 months ago (2016-05-25 20:43:58 UTC) #7
michaelpg
lgtm
4 years, 6 months ago (2016-05-26 18:04:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009783003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009783003/40001
4 years, 6 months ago (2016-05-26 18:13:59 UTC) #10
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/settings/settings.html: While running git apply --index -3 -p1; error: patch ...
4 years, 6 months ago (2016-05-26 18:42:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009783003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009783003/60001
4 years, 6 months ago (2016-05-26 19:19:02 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 6 months ago (2016-05-26 21:27:11 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 21:29:02 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3204336053295d134ab7844403393b23cae1f057
Cr-Commit-Position: refs/heads/master@{#396285}

Powered by Google App Engine
This is Rietveld 408576698