Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2009773007: Add AntiVirus information to the system profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review fixes part 2 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/chrome_metrics_service_client.h" 5 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 #include "chrome/browser/metrics/plugin_metrics_provider.h" 80 #include "chrome/browser/metrics/plugin_metrics_provider.h"
81 #endif 81 #endif
82 82
83 #if defined(OS_CHROMEOS) 83 #if defined(OS_CHROMEOS)
84 #include "chrome/browser/metrics/chromeos_metrics_provider.h" 84 #include "chrome/browser/metrics/chromeos_metrics_provider.h"
85 #include "chrome/browser/signin/signin_status_metrics_provider_chromeos.h" 85 #include "chrome/browser/signin/signin_status_metrics_provider_chromeos.h"
86 #endif 86 #endif
87 87
88 #if defined(OS_WIN) 88 #if defined(OS_WIN)
89 #include <windows.h> 89 #include <windows.h>
90 #include "chrome/browser/metrics/antivirus_metrics_provider_win.h"
90 #include "chrome/browser/metrics/google_update_metrics_provider_win.h" 91 #include "chrome/browser/metrics/google_update_metrics_provider_win.h"
91 #include "chrome/common/metrics_constants_util_win.h" 92 #include "chrome/common/metrics_constants_util_win.h"
92 #include "chrome/installer/util/browser_distribution.h" 93 #include "chrome/installer/util/browser_distribution.h"
93 #include "components/browser_watcher/watcher_metrics_provider_win.h" 94 #include "components/browser_watcher/watcher_metrics_provider_win.h"
94 #endif 95 #endif
95 96
96 #if !defined(OS_CHROMEOS) 97 #if !defined(OS_CHROMEOS)
97 #include "chrome/browser/signin/chrome_signin_status_metrics_provider_delegate.h " 98 #include "chrome/browser/signin/chrome_signin_status_metrics_provider_delegate.h "
98 #include "components/signin/core/browser/signin_status_metrics_provider.h" 99 #include "components/signin/core/browser/signin_status_metrics_provider.h"
99 #endif // !defined(OS_CHROMEOS) 100 #endif // !defined(OS_CHROMEOS)
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 google_update_metrics_provider_ = new GoogleUpdateMetricsProviderWin; 439 google_update_metrics_provider_ = new GoogleUpdateMetricsProviderWin;
439 metrics_service_->RegisterMetricsProvider( 440 metrics_service_->RegisterMetricsProvider(
440 std::unique_ptr<metrics::MetricsProvider>( 441 std::unique_ptr<metrics::MetricsProvider>(
441 google_update_metrics_provider_)); 442 google_update_metrics_provider_));
442 443
443 metrics_service_->RegisterMetricsProvider( 444 metrics_service_->RegisterMetricsProvider(
444 std::unique_ptr<metrics::MetricsProvider>( 445 std::unique_ptr<metrics::MetricsProvider>(
445 new browser_watcher::WatcherMetricsProviderWin( 446 new browser_watcher::WatcherMetricsProviderWin(
446 chrome::GetBrowserExitCodesRegistryPath(), 447 chrome::GetBrowserExitCodesRegistryPath(),
447 content::BrowserThread::GetBlockingPool()))); 448 content::BrowserThread::GetBlockingPool())));
449
450 antivirus_metrics_provider_ = new AntiVirusMetricsProvider(
451 content::BrowserThread::GetMessageLoopProxyForThread(
452 content::BrowserThread::FILE));
Alexei Svitkine (slow) 2016/06/03 15:48:34 Any reason to use FILE instead of the worker pool?
Will Harris 2016/06/03 20:51:30 I was using the same thread that GetDriveMetrics r
453
454 metrics_service_->RegisterMetricsProvider(
455 std::unique_ptr<metrics::MetricsProvider>(antivirus_metrics_provider_));
448 #endif // defined(OS_WIN) 456 #endif // defined(OS_WIN)
449 457
450 #if defined(ENABLE_PLUGINS) 458 #if defined(ENABLE_PLUGINS)
451 plugin_metrics_provider_ = 459 plugin_metrics_provider_ =
452 new PluginMetricsProvider(g_browser_process->local_state()); 460 new PluginMetricsProvider(g_browser_process->local_state());
453 metrics_service_->RegisterMetricsProvider( 461 metrics_service_->RegisterMetricsProvider(
454 std::unique_ptr<metrics::MetricsProvider>(plugin_metrics_provider_)); 462 std::unique_ptr<metrics::MetricsProvider>(plugin_metrics_provider_));
455 #endif // defined(ENABLE_PLUGINS) 463 #endif // defined(ENABLE_PLUGINS)
456 464
457 #if defined(OS_CHROMEOS) 465 #if defined(OS_CHROMEOS)
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 weak_ptr_factory_.GetWeakPtr()); 524 weak_ptr_factory_.GetWeakPtr());
517 525
518 #if defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD) 526 #if defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD)
519 google_update_metrics_provider_->GetGoogleUpdateData(got_metrics_callback); 527 google_update_metrics_provider_->GetGoogleUpdateData(got_metrics_callback);
520 #else 528 #else
521 got_metrics_callback.Run(); 529 got_metrics_callback.Run();
522 #endif // defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD) 530 #endif // defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD)
523 } 531 }
524 532
525 void ChromeMetricsServiceClient::OnInitTaskGotGoogleUpdateData() { 533 void ChromeMetricsServiceClient::OnInitTaskGotGoogleUpdateData() {
534 const base::Closure got_metrics_callback =
535 base::Bind(&ChromeMetricsServiceClient::OnInitTaskGotAntiVirusData,
536 weak_ptr_factory_.GetWeakPtr());
537
538 #if defined(OS_WIN)
539 antivirus_metrics_provider_->GetAntiVirusMetrics(got_metrics_callback);
540 #else
541 got_metrics_callback.Run();
542 #endif // defined(OS_WIN)
543 }
544
545 void ChromeMetricsServiceClient::OnInitTaskGotAntiVirusData() {
526 drive_metrics_provider_->GetDriveMetrics( 546 drive_metrics_provider_->GetDriveMetrics(
527 base::Bind(&ChromeMetricsServiceClient::OnInitTaskGotDriveMetrics, 547 base::Bind(&ChromeMetricsServiceClient::OnInitTaskGotDriveMetrics,
528 weak_ptr_factory_.GetWeakPtr())); 548 weak_ptr_factory_.GetWeakPtr()));
529 } 549 }
530 550
531 void ChromeMetricsServiceClient::OnInitTaskGotDriveMetrics() { 551 void ChromeMetricsServiceClient::OnInitTaskGotDriveMetrics() {
532 finished_init_task_callback_.Run(); 552 finished_init_task_callback_.Run();
533 } 553 }
534 554
535 bool ChromeMetricsServiceClient::ShouldIncludeProfilerDataInLog() { 555 bool ChromeMetricsServiceClient::ShouldIncludeProfilerDataInLog() {
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
710 } 730 }
711 } 731 }
712 732
713 void ChromeMetricsServiceClient::OnURLOpenedFromOmnibox(OmniboxLog* log) { 733 void ChromeMetricsServiceClient::OnURLOpenedFromOmnibox(OmniboxLog* log) {
714 metrics_service_->OnApplicationNotIdle(); 734 metrics_service_->OnApplicationNotIdle();
715 } 735 }
716 736
717 bool ChromeMetricsServiceClient::IsUMACellularUploadLogicEnabled() { 737 bool ChromeMetricsServiceClient::IsUMACellularUploadLogicEnabled() {
718 return metrics::IsCellularLogicEnabled(); 738 return metrics::IsCellularLogicEnabled();
719 } 739 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698