Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2009773004: Remove reference to compiler from libary loader, fix analyzer warning (Closed)

Created:
4 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 7 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove reference to compiler from libary loader, fix analyzer warning R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/266ad7fd0f6f8eef66ed71be8e8700ed06e3dbb0

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 5 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Siggi Cherem (dart-lang)
4 years, 7 months ago (2016-05-25 22:19:13 UTC) #2
Harry Terkelsen
lgtm https://codereview.chromium.org/2009773004/diff/1/pkg/compiler/lib/src/library_loader.dart File pkg/compiler/lib/src/library_loader.dart (right): https://codereview.chromium.org/2009773004/diff/1/pkg/compiler/lib/src/library_loader.dart#newcode388 pkg/compiler/lib/src/library_loader.dart:388: repoter.reportCrashInUserCode( repoter -> reporter
4 years, 7 months ago (2016-05-25 22:21:26 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2009773004/diff/1/pkg/compiler/lib/src/library_loader.dart File pkg/compiler/lib/src/library_loader.dart (right): https://codereview.chromium.org/2009773004/diff/1/pkg/compiler/lib/src/library_loader.dart#newcode388 pkg/compiler/lib/src/library_loader.dart:388: repoter.reportCrashInUserCode( On 2016/05/25 22:21:26, Harry Terkelsen wrote: > repoter ...
4 years, 7 months ago (2016-05-25 22:26:10 UTC) #4
Siggi Cherem (dart-lang)
4 years, 7 months ago (2016-05-25 22:27:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
266ad7fd0f6f8eef66ed71be8e8700ed06e3dbb0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698