Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Issue 2009773003: [Smart Lock] Adds UMA Metrics for actions on Account Chooser. (Closed)

Created:
4 years, 7 months ago by melandory
Modified:
4 years, 6 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Adds UMA Metrics for actions on Account Chooser. One account, many accounts case. BUG=611006 Committed: https://crrev.com/2a08dfb353a0d877f974a9bbf0eb489dbe0a18bb Cr-Commit-Position: refs/heads/master@{#396696}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M chrome/browser/password_manager/account_chooser_dialog_android.cc View 2 2 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009773003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009773003/20001
4 years, 7 months ago (2016-05-25 15:03:15 UTC) #2
melandory
PTAL, thanks!
4 years, 7 months ago (2016-05-25 15:03:48 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/11182) ios-device-gn on ...
4 years, 7 months ago (2016-05-25 15:04:58 UTC) #7
vasilii
Your CL is out of date with your own changes in https://codereview.chromium.org/1973293002/
4 years, 7 months ago (2016-05-25 15:12:11 UTC) #8
melandory
On 2016/05/25 15:12:11, vasilii wrote: > Your CL is out of date with your own ...
4 years, 6 months ago (2016-05-30 08:22:18 UTC) #10
vasilii
lgtm
4 years, 6 months ago (2016-05-30 08:30:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009773003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009773003/80001
4 years, 6 months ago (2016-05-30 08:48:33 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 6 months ago (2016-05-30 08:52:00 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 08:52:55 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a08dfb353a0d877f974a9bbf0eb489dbe0a18bb
Cr-Commit-Position: refs/heads/master@{#396696}

Powered by Google App Engine
This is Rietveld 408576698