ui/native_theme/native_theme_base.h - Issue 2009733002: Draw nicer arrows when the scrollbar buttons are not square.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/native_theme/native_theme_base.h

Issue 2009733002: Draw nicer arrows when the scrollbar buttons are not square. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review edits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/native_theme/native_theme_base.h

diff --git a/ui/native_theme/native_theme_base.h b/ui/native_theme/native_theme_base.h

index 74525ce67fbf4dfcbbc7d2cc3356ae6d797178e2..e11fe780bea6ad73129027af4f1769fa3e14bdc8 100644

--- a/ui/native_theme/native_theme_base.h

+++ b/ui/native_theme/native_theme_base.h

@@ -11,6 +11,7 @@

#include "base/gtest_prod_util.h"

#include "base/macros.h"

#include "skia/ext/platform_canvas.h"

+#include "ui/gfx/geometry/rect_f.h"

#include "ui/native_theme/native_theme.h"

namespace gfx {

@@ -170,10 +171,10 @@ class NATIVE_THEME_EXPORT NativeThemeBase : public NativeTheme {

SkColor GetArrowColor(State state) const;

private:

- FRIEND_TEST_ALL_PREFIXES(NativeThemeAuraTest, VerticalArrows);

- FRIEND_TEST_ALL_PREFIXES(NativeThemeAuraTest, HorizontalArrows);

+ friend class NativeThemeAuraTest;

SkPath PathForArrow(const gfx::Rect& rect, Part direction) const;

+ gfx::RectF BoundingRectForArrow(const gfx::Rect& rect) const;

void DrawVertLine(SkCanvas* canvas,

int x,

« no previous file with comments | « ui/native_theme/native_theme_aura_unittest.cc ('k') | ui/native_theme/native_theme_base.cc » ('j') | ui/native_theme/native_theme_base.cc » ('J')