Issue 20097: Allow purify scripts to take a --report_dir argument which specifies where th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20097: Allow purify scripts to take a --report_dir argument which specifies where th... (Closed)

Created:
11 years, 10 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Allow purify scripts to take a --report_dir argument which specifies where the output data is written to. Also, add a --buildbot flag which will default the report_dir to a specific directory on chrome-web. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9286

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1

Patch Set 6 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -28 lines)			Patch
M	tools/purify/chrome_tests.py	View	1 2 3 4 5	4 chunks	+31 lines, -2 lines	0 comments	Download
M	tools/purify/purify_analyze.py	View	1 2 3	11 chunks	+36 lines, -21 lines	0 comments	Download
M	tools/purify/purify_test.py	View	1 2 3	5 chunks	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

11 years, 10 months ago (2009-02-06 00:03:00 UTC) #2

LG with the comment

http://codereview.chromium.org/20097/diff/15/1014
File tools/purify/chrome_tests.py (right):

http://codereview.chromium.org/20097/diff/15/1014#newcode68
Line 68: chrome_web_dir = "//chrome-web.corp.google.com/chrome-bot/www/purify"
you need to do 
import chromium_config as config
chrome_web_dir = config.Archive.purify_test_result_archive
I already created it.

Expand Messages | Collapse Messages