Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2009693002: Create SurfaceManager with ui::InitializeContextFactoryForTests (Closed)

Created:
4 years, 7 months ago by jbauman
Modified:
4 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create SurfaceManager with ui::InitializeContextFactoryForTests This allows tests that create Surfaces to work. BUG=610086 Committed: https://crrev.com/e3f55a5ad23fdcf4782bff12a6e5b39741ac9e72 Cr-Commit-Position: refs/heads/master@{#395972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M ui/compositor/test/context_factories_for_test.cc View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
jbauman
4 years, 7 months ago (2016-05-25 01:44:47 UTC) #3
piman
lgtm
4 years, 6 months ago (2016-05-25 19:34:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009693002/1
4 years, 6 months ago (2016-05-25 20:02:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-25 20:08:11 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-25 20:10:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3f55a5ad23fdcf4782bff12a6e5b39741ac9e72
Cr-Commit-Position: refs/heads/master@{#395972}

Powered by Google App Engine
This is Rietveld 408576698