Avoid a copy in the debug check in GetStringFUTF16().

Avoid a copy in the debug check in GetStringFUTF16().

Committed: https://crrev.com/9dd439b97b2aad562ea8656f3503226613b9b96f
Cr-Commit-Position: refs/heads/master@{#395917}

[Lei Zhang, 2016-05-25 00:07:02]

thestig@chromium.org changed reviewers:
+ jshin@chromium.org

[Lei Zhang, 2016-05-25 00:07:03]

https://codereview.chromium.org/2009683002/diff/1/ui/base/l10n/l10n_util.cc
File ui/base/l10n/l10n_util.cc (right):

https://codereview.chromium.org/2009683002/diff/1/ui/base/l10n/l10n_util.cc#n...
ui/base/l10n/l10n_util.cc:707: placeholder += (L'1' + i);
At least Linux didn't like having this as part of the previous line.

https://codereview.chromium.org/2009683002/diff/1/ui/base/l10n/l10n_util.cc#n...
ui/base/l10n/l10n_util.cc:710: DCHECK_NE(std::string::npos, pos) << " Didn't
find a " << placeholder
This is just "git cl format" lining things up.

https://codereview.chromium.org/2009683002/diff/1/ui/base/l10n/l10n_util.cc#n...
ui/base/l10n/l10n_util.cc:867: // TODO(jungshik) : Put them at the end of the
list with language codes
I think that's what you meant to say?

[jungshik at Google, 2016-05-25 07:37:05]

https://codereview.chromium.org/2009683002/diff/1/ui/base/l10n/l10n_util.cc
File ui/base/l10n/l10n_util.cc (right):

https://codereview.chromium.org/2009683002/diff/1/ui/base/l10n/l10n_util.cc#n...
ui/base/l10n/l10n_util.cc:707: placeholder += (L'1' + i);
On 2016/05/25 00:07:02, Lei Zhang wrote:
> At least Linux didn't like having this as part of the previous line.

|L'1'| is wchar_t (32-bit) on Linux/Mac. Didn't you get any warning from
compilers?

[jungshik at Google, 2016-05-25 08:26:35]

LGTM

https://codereview.chromium.org/2009683002/diff/1/ui/base/l10n/l10n_util.cc
File ui/base/l10n/l10n_util.cc (right):

https://codereview.chromium.org/2009683002/diff/1/ui/base/l10n/l10n_util.cc#n...
ui/base/l10n/l10n_util.cc:707: placeholder += (L'1' + i);
On 2016/05/25 07:37:05, jshin (slow- 23-26) wrote:
> On 2016/05/25 00:07:02, Lei Zhang wrote:
> > At least Linux didn't like having this as part of the previous line.
> 
> |L'1'| is wchar_t (32-bit) on Linux/Mac. Didn't you get any warning from
> compilers? 

oh. trybots all come back green.

[Lei Zhang, 2016-05-25 17:10:13]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-05-25 17:10:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009683002/1

[commit-bot: I haz the power, 2016-05-25 17:15:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-25 17:16:51]

Description was changed from

==========
Avoid a copy in the debug check in GetStringFUTF16().
==========

to

==========
Avoid a copy in the debug check in GetStringFUTF16().

Committed: https://crrev.com/9dd439b97b2aad562ea8656f3503226613b9b96f
Cr-Commit-Position: refs/heads/master@{#395917}
==========

[commit-bot: I haz the power, 2016-05-25 17:16:52]

Patchset 1 (id:??) landed as
https://crrev.com/9dd439b97b2aad562ea8656f3503226613b9b96f
Cr-Commit-Position: refs/heads/master@{#395917}