Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2009673004: Fix flash of bullet point on refresh of neterror page (Closed)

Created:
4 years, 7 months ago by edwardjung
Modified:
4 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flash of bullet point on refresh of neterror page BUG=599439 Committed: https://crrev.com/af3221d23aeb883f73ff08c947d283d493e78868 Cr-Commit-Position: refs/heads/master@{#396194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/neterror/resources/neterror.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
edwardjung
Using display:none as previously suggested to hide the suggestions block until JS template code kicks ...
4 years, 7 months ago (2016-05-26 11:24:35 UTC) #2
mmenke
On 2016/05/26 11:24:35, edwardjung wrote: > Using display:none as previously suggested to hide the suggestions ...
4 years, 7 months ago (2016-05-26 14:46:11 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009673004/1
4 years, 7 months ago (2016-05-26 15:32:56 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-26 16:17:05 UTC) #7
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 16:17:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009673004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009673004/1
4 years, 7 months ago (2016-05-26 16:23:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 16:27:37 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 16:29:30 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/af3221d23aeb883f73ff08c947d283d493e78868
Cr-Commit-Position: refs/heads/master@{#396194}

Powered by Google App Engine
This is Rietveld 408576698