PPC: [build] Fix a clang warning

PPC: [build] Fix a clang warning

Port a23222ed32d8a4829af1dc33f93ca599fef6c50a

Original commit message:

    For cross-compiler-compatibility and standards compliance %p
    requires a void*, rather than any pointer type.

R=machenbach@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=chromium:474921
LOG=N

Committed: https://crrev.com/8b295a0e3f1ef150fbeb925ea604f962ad74e3d9
Cr-Commit-Position: refs/heads/master@{#36519}

[JaideepBajwa, 2016-05-24 22:22:47]

PTAL

[Michael Achenbach, 2016-05-25 06:40:29]

lgtm with comment

https://codereview.chromium.org/2009653002/diff/1/src/ppc/simulator-ppc.cc
File src/ppc/simulator-ppc.cc (right):

https://codereview.chromium.org/2009653002/diff/1/src/ppc/simulator-ppc.cc#ne...
src/ppc/simulator-ppc.cc:1287:
reinterpret_cast<void*>(FUNCTION_ADDR(generic_target)),
I assume FUNCTION_ADDR already returns a pointer. So I suggest using static_cast
instead for all 4 changes.

[JaideepBajwa, 2016-05-25 14:11:30]

On 2016/05/25 06:40:29, Michael Achenbach (slow) wrote:
> lgtm with comment
> 
> https://codereview.chromium.org/2009653002/diff/1/src/ppc/simulator-ppc.cc
> File src/ppc/simulator-ppc.cc (right):
> 
>
https://codereview.chromium.org/2009653002/diff/1/src/ppc/simulator-ppc.cc#ne...
> src/ppc/simulator-ppc.cc:1287:
> reinterpret_cast<void*>(FUNCTION_ADDR(generic_target)),
> I assume FUNCTION_ADDR already returns a pointer. So I suggest using
static_cast
> instead for all 4 changes.

updated.

[JaideepBajwa, 2016-05-25 14:25:53]

The CQ bit was checked by bjaideep@ca.ibm.com

[JaideepBajwa, 2016-05-25 14:25:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2009653002/#ps20001
(title: "updated to use static_cast")

[commit-bot: I haz the power, 2016-05-25 14:26:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009653002/20001

[Michael Achenbach, 2016-05-25 14:32:16]

lgtm

[commit-bot: I haz the power, 2016-05-25 14:48:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-25 14:49:26]

Description was changed from

==========
PPC: [build] Fix a clang warning

Port a23222ed32d8a4829af1dc33f93ca599fef6c50a

Original commit message:

    For cross-compiler-compatibility and standards compliance %p
    requires a void*, rather than any pointer type.

R=machenbach@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=chromium:474921
LOG=N
==========

to

==========
PPC: [build] Fix a clang warning

Port a23222ed32d8a4829af1dc33f93ca599fef6c50a

Original commit message:

    For cross-compiler-compatibility and standards compliance %p
    requires a void*, rather than any pointer type.

R=machenbach@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com,
michael_dawson@ca.ibm.com, mbrandy@us.ibm.com

BUG=chromium:474921
LOG=N

Committed: https://crrev.com/8b295a0e3f1ef150fbeb925ea604f962ad74e3d9
Cr-Commit-Position: refs/heads/master@{#36519}
==========

[commit-bot: I haz the power, 2016-05-25 14:49:27]

Patchset 2 (id:??) landed as
https://crrev.com/8b295a0e3f1ef150fbeb925ea604f962ad74e3d9
Cr-Commit-Position: refs/heads/master@{#36519}