chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 2009643003: [Mac][Material Design] Restore bookmark icons to default favicon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 2009643003: [Mac][Material Design] Restore bookmark icons to default favicon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index 1dc45f1d0fec551f689d1c6843473159cd4fdf25..4851e197f568f7c7788919e9f7c115ba4bb1a4f1 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -318,11 +318,11 @@ CGFloat BookmarkRightMargin() {

const int kIconSize = 16;

defaultImage_.reset([NSImageFromImageSkia(

- gfx::CreateVectorIcon(gfx::VectorIconId::LOCATION_BAR_HTTP,

+ gfx::CreateVectorIcon(gfx::VectorIconId::DEFAULT_FAVICON,

kIconSize,

gfx::kChromeIconGrey)) retain]);

defaultImageIncognito_.reset([NSImageFromImageSkia(

- gfx::CreateVectorIcon(gfx::VectorIconId::LOCATION_BAR_HTTP,

+ gfx::CreateVectorIcon(gfx::VectorIconId::DEFAULT_FAVICON,

kIconSize,

SkColorSetA(SK_ColorWHITE, 0xCC))) retain]);

} else {

« no previous file with comments | « no previous file | ui/gfx/vector_icons/default_favicon.icon » ('j') | ui/gfx/vector_icons/default_favicon.icon » ('J')